Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spree Upgrade] Order edit page is not filtering shipping methods by the order distributor #3607

Closed
luisramos0 opened this issue Mar 15, 2019 · 5 comments
Assignees
Labels
bug-s1 The bug is stopping the platform from working, and there is no workaround. Impact of lot of users.

Comments

@luisramos0
Copy link
Contributor

luisramos0 commented Mar 15, 2019

Description

When editing an order we can see the full list of shipping methods in the system.

Expected Behavior

We should see only shipping methods of the order's distributor.

Actual Behaviour

We see the full list of shipping methods in the system.

Steps to Reproduce

Open any order, edit shipping method and check the list.

Animated Gif/Screenshot

Example from my local instance with sanitized AUS live data (I see 500+ shipping methods for any order)
Screenshot 2019-03-15 at 12 40 50

Context

Found while testing #3527

Severity

bug-s1: a critical feature is broken: checkout, payments, signup, login

@luisramos0
Copy link
Contributor Author

This issue is fixed by a PR in spree: openfoodfoundation/spree#39

@RachL
Copy link
Contributor

RachL commented Mar 15, 2019

thx @luisramos0 ! I wanted to open this but didn't have time since yesterday, sorry !

@luisramos0
Copy link
Contributor Author

it's ok, I opened it because I created the PR for it.
can you open the email one?

@sauloperez
Copy link
Contributor

I might have been too fast in merging openfoodfoundation/spree#39 but this should be solved as soon as we pull that new commit in OFN's Gemfile.lock.

@luisramos0
Copy link
Contributor Author

thanks. I think we are good, I'll create a new PR to bring spree39 to ofn. That PR can be manually tested and will close this issue.

@luisramos0 luisramos0 added bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround. bug-s1 The bug is stopping the platform from working, and there is no workaround. Impact of lot of users. and removed bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround. labels Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s1 The bug is stopping the platform from working, and there is no workaround. Impact of lot of users.
Projects
None yet
Development

No branches or pull requests

3 participants