New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spree Upgrade] Fix edit ship method and tracking number in backoffice order page #3527
[Spree Upgrade] Fix edit ship method and tracking number in backoffice order page #3527
Conversation
The data-hook is necessary to make spree js code work, in this case, activate click events on edit and save buttons
8c9b035
to
b73ca88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! And we thought data-hooks were only used to deface...
I have no idea whether we've had the discussion already but I think is worth now going through the regular testing process. AFAIK these things can be manually tested. |
we have discussed that in another PR Pau, I think we can start to do that when we finish the basic testing in staging FR. After the basic test we can go through these PRs and make a list of things to test: there are quite a few of them. |
so, I'd just merge this for now. |
@luisramos0 @sauloperez so this can be removed from testing column? :) |
Editing method and tracking works. However I tested this with a new account, and in 2 different situation I saw "UPS ground" displayed has a shipping method also the enterprise I created does not have "UPS ground has a shipping method:
Shall I open a new issue for this or is there a simple explanation? https://docs.google.com/document/d/1rxYOrDI-SBNjoycqQ_OQNo4WU0RPtFprvlgVruzPKdo/edit# |
Oh and also I noticed that the shipping confirmation email was not send. Could this be linekd to this PR? @luisramos0 ? |
Nice, thanks for testing! Lets open new issues for those two problems (shipping methods and shipment confirmation email) |
I have created #3607 for the shipping methods problem. |
I have created #3616 for the email issue. Thank you Luis! And sorry for the delay creating this. |
What? Why?
Editing shipping method and tracking number in the order edit page was not working. This PR fixes that by adding a missing data-hook that makes the spree JS code work and trigger the correct click events and all the logic to edit ship method and tracking number.
What should we test?
Edit an order's shipping method and tracking number.