-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shopfront: Force product description to be on one line #10538
Shopfront: Force product description to be on one line #10538
Conversation
Before : after: sooo I guess I copied some blank spaces. But thing is (as we don't allow the user to see the html source #trolling ) I have no way of removing it. @jibees any clue on how to fix this? Here is the text I have used: https://www.loremipzum.com/fr/g%C3%A9n%C3%A9rateur-de-texte Moving back in dev for now. |
6b79dbc
to
d56ae05
Compare
d56ae05
to
1de9f5a
Compare
and make it as a `div`
1de9f5a
to
4dfc569
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix!
I wonder if we could also remove other empty nodes, but that's not necessary because none of the other types result in new lines.
This should be tested in both Safari and another major browser. Also on an Apple phone if possible, or emulate it on a computer.
Before: Bold italic etc still work as well: this looks good to me! thanks @jibees merging :) |
What? Why?
What should we test?
(This should be tested in both Safari and another major browser. And on mobile phones.)
Release notes
Changelog Category: User facing changes
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates