Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move webpack-* as dependency (not devDependencies) #10594

Conversation

jibees
Copy link
Contributor

@jibees jibees commented Mar 21, 2023

What? Why?

What should we test?

Capture d’écran 2023-03-21 à 14 44 56

Release notes

Changelog Category: Technical changes

@jibees jibees self-assigned this Mar 21, 2023
@jibees jibees marked this pull request as ready for review March 21, 2023 13:45
@filipefurtad0 filipefurtad0 added pr-staged-uk staging.openfoodnetwork.org.uk pr-staged-au staging.openfoodnetwork.org.au and removed pr-staged-uk staging.openfoodnetwork.org.uk pr-staged-au staging.openfoodnetwork.org.au labels Mar 21, 2023
Copy link
Contributor

@filipefurtad0 filipefurtad0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes deployments - tested in staging-UK and -AU - and performed a quick smoke test by checking checking out and checking the app, visually. Spotted nothing, so approving and merging.

Thanks @jibees !

@filipefurtad0 filipefurtad0 merged commit 84f3198 into openfoodfoundation:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment failed on master
2 participants