Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.22.2 to 2.23.0 #11945

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2023

Bumps rubocop-rails from 2.22.2 to 2.23.0.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 1.23.0 (The RubyConf Taiwan 2023 Edition)

New features

Bug fixes

  • #1206: Fix an error for Rails/WhereMissing where join method is called without arguments. (@​fatkodima)
  • #1189: Fix false negatives for Rails/Pluck when using safe navigation method calls. (@​koic)
  • #1204: Make Rails/ActiveSupportAliases, Rails/FindBy, Rails/FindById, Rails/Inquiry, Rails/Pick Rails/PluckId, Rails/PluckInWhere, Rails/WhereEquals, Rails/WhereExists, and Rails/WhereNot cops aware of safe navigation operator. (@​koic)

Changes

Changelog

Sourced from rubocop-rails's changelog.

2.23.0 (2023-12-16)

New features

Bug fixes

  • #1206: Fix an error for Rails/WhereMissing where join method is called without arguments. ([@​fatkodima][])
  • #1189: Fix false negatives for Rails/Pluck when using safe navigation method calls. ([@​koic][])
  • #1204: Make Rails/ActiveSupportAliases, Rails/FindBy, Rails/FindById, Rails/Inquiry, Rails/Pick Rails/PluckId, Rails/PluckInWhere, Rails/WhereEquals, Rails/WhereExists, and Rails/WhereNot cops aware of safe navigation operator. ([@​koic][])

Changes

Commits
  • bdc741d Cut 2.23.0
  • cbd9eeb Update Changelog
  • cc81598 Merge pull request #1204 from koic/make_some_cops_aware_of_safe_navigation_op...
  • 7c672a0 Make some cops aware of safe navigation operator
  • a3db656 Merge pull request #1216 from fatkodima/pluck_in_where-ids
  • b9e40e1 Update Rails/PluckInWhere to check for .ids call
  • 1431257 Merge pull request #1209 from fatkodima/pluck_in_where-where-not
  • d9c2a44 Support where.not for Rails/PluckInWhere
  • 2776841 Merge pull request #1181 from r7kamura/nokogiri-html-parse
  • a280038 Merge pull request #1208 from fatkodima/fix-where-missing-error
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.22.2 to 2.23.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.22.2...v2.23.0)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Dec 18, 2023
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, Rails/Pluck detects one more case we should fix. We have many more pre-existing cases though. So I'll just regenerate the todo file for now.

@mkllnk mkllnk merged commit 6d5f07c into master Dec 20, 2023
@mkllnk mkllnk deleted the dependabot/bundler/rubocop-rails-2.23.0 branch December 20, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant