Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump knapsack_pro from 6.0.4 to 7.0.1 #12261

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 12, 2024

Bumps knapsack_pro from 6.0.4 to 7.0.1.

Changelog

Sourced from knapsack_pro's changelog.

7.0.1

  • fix(RSpec): conditionally adds --require rails_helper to cli arguments of KnapsackPro::Runners::Queue::RSpecRunner. Version 7.0.0 introduced some fundamental changes, namely fetching, loading and running batches of specs after executing suite hooks, so that such hooks are only ran once, not before every batch. As a result, if rails_helper is only required in spec files, which is the RSpec default, instead of e.g. in .rspec, then some before(:suite) hooks, e.g. defined by gems, are registered after suite hooks had already been executed by the test suite. By comparison, RSpec loads all the spec files before executing before(:suite) hooks.

PR with the above changes: KnapsackPro/knapsack_pro-ruby#243

KnapsackPro/knapsack_pro-ruby@v7.0.0...v7.0.1

7.0.0

  • (breaking change) RSpec in Queue Mode:

    • The default for KNAPSACK_PRO_LOG_LEVEL is info instead of debug.

    • The RSpec before(:suite) and after(:suite) hooks changed:

      Before: The before(:suite) and after(:suite) hooks were executed multiple times. Each time for a batch of tests fetched from Knapsack Pro Queue API.

      After: The before(:suite) and after(:suite) hooks are executed only once: before(:suite) is executed before starting tests, after(:suite) is executed after all tests are completed. (It is what you would expect from RSpec).

    • The KnapsackPro::Hooks::Queue.after_queue hook change:

      Before: The KnapsackPro::Hooks::Queue.after_queue hook is executed outside of the after(:suite) hook.

      After: The KnapsackPro::Hooks::Queue.after_queue hook is executed inside of the after(:suite) hook.

  • Recommended RSpec changes in your project:

    • Remove the following code if you use Queue Mode and the rspec_junit_formatter gem to generate JUnit XML or JSON reports:

      # REMOVE THE FOLLOWING CODE
      spec_helper.rb or rails_helper.rb
      TMP_REPORT = "tmp/rspec_#{ENV['KNAPSACK_PRO_CI_NODE_INDEX']}.xml"
      FINAL_REPORT = "tmp/final_rspec_#{ENV['KNAPSACK_PRO_CI_NODE_INDEX']}.xml"
      KnapsackPro::Hooks::Queue.after_subset_queue do |queue_id, subset_queue_id|
      if File.exist?(TMP_REPORT)
      FileUtils.mv(TMP_REPORT, FINAL_REPORT)
      end
      end

      Learn more about using Knapsack Pro with RSpec formatters and using Knapsack Pro with CircleCI in the docs.

    • Replace the following code if you are using Queue Mode and the percy-capybara gem on a version older than 4:

      Before:

... (truncated)

Commits
  • 45d7c13 Bump version 7.0.1
  • 15101b8 Merge pull request #243 from KnapsackPro/require-rails-helper
  • 80e389d Review updates
  • 8da0732 Add --require rails_helper to cli args
  • 3e02c29 Merge pull request #245 from KnapsackPro/refactor-integration-tests
  • d9623b3 refactor(integration tests): use stub instead of mock wording
  • 6c7b81c Merge pull request #244 from KnapsackPro/update-publishing-readme
  • 0dce72a Update publishing readme
  • 87394d7 add missing spec for KnapsackPro::Formatters::TimeTrackerFetcher
  • f7936cf Bump version 7.0.0
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Mar 12, 2024
@dependabot dependabot bot force-pushed the dependabot/bundler/knapsack_pro-7.0.1 branch from 605d812 to a716573 Compare April 3, 2024 22:29
@filipefurtad0
Copy link
Contributor

@dependabot rebase

Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby) from 6.0.4 to 7.0.1.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md)
- [Commits](KnapsackPro/knapsack_pro-ruby@v6.0.4...v7.0.1)

---
updated-dependencies:
- dependency-name: knapsack_pro
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/knapsack_pro-7.0.1 branch from a716573 to 5ff786f Compare April 4, 2024 15:16
Copy link
Contributor Author

dependabot bot commented on behalf of github May 1, 2024

Superseded by #12424.

@dependabot dependabot bot closed this May 1, 2024
@dependabot dependabot bot deleted the dependabot/bundler/knapsack_pro-7.0.1 branch May 1, 2024 10:05
@filipefurtad0 filipefurtad0 mentioned this pull request May 7, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant