-
-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump stimulus_reflex to 3.5.1 and cable_ready to 5.0.5 #12472
Bump stimulus_reflex to 3.5.1 and cable_ready to 5.0.5 #12472
Conversation
Bumps [stimulus_reflex](https://github.com/stimulusreflex/stimulus_reflex) from 3.5.0-rc3 to 3.5.0-rc4. - [Release notes](https://github.com/stimulusreflex/stimulus_reflex/releases) - [Changelog](https://github.com/stimulusreflex/stimulus_reflex/blob/main/CHANGELOG.md) - [Commits](https://github.com/stimulusreflex/stimulus_reflex/commits) --- updated-dependencies: - dependency-name: stimulus_reflex dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Gem and package need to be in sync.
Unfortunately the testing framework doesn't support the latest version of StimulusReflex. This is a third party framework that doesn't seem to be maintained. Maybe we should convert these to ActionCable tests.
It contains a fix for stimulus_reflex 3.5.0-rc4, but hasn't been released yet. podia/stimulus_reflex_testing#21 Now the user reflex spec works, but the products spec needs another fix. But we plan to remove it soon anyway.
There wasn't a simple path to upgrade them separately. I think it's fine to do both at once.
I ran stimulus_reflex:install. It skipped over most things, but did add gem redis-session-store without explanation. It's mentioned in the [documentation](https://docs.stimulusreflex.com/hello-world/setup.html#session-storage), but I don't think it's relevant to us so I removed it again.
Doesn't matter how many times I stop spring, clear cache or restart the dev server, it refuses to acknowledge the cable_ready version. Seems to be the same problem on CI. See
This was the same problem back here: #12235 (comment) |
Yes, looks like v5.0.5 will fix this stimulusreflex/cable_ready@v5.0.4...v5.0.5 👍 |
🙄 Groan, why couldn't they have released it a day earlier and saved my time!!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes it really doesn't seem worth it to work with bleeding-edge tools. These updates have been painful.
I agree. I actually delayed updating these gems, but decided we should keep them relatively up to date while we still use them. |
Moving to test ready as its quite similar to the previously approved PR. |
Hey @dacook , Tested what you've suggested - thanks so much for that:
Merging. |
main
(because latest fixes haven't been released yet).As of 20 May 2024, there's only one unsolved new issue, but it doesn't seem to affect this codebase.
I'd recommend just viewing the overall diff, which shows just the upgrades as described above.
What should we test?
These are underlying frameworks used for the dynamic functionality on the below pages. Simply checking that they work as usual, with no errors in the dev console should be sufficient.
/admin/products
withadmin_style_v3
)/admin/reports/packing/customer
(old or new design, doesn't matter)Dependencies