Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Paypal system spec to consider new checkout flow #12494

Conversation

filipefurtad0
Copy link
Contributor

What? Why?

Updates Paypal system spec to consider new checkout flow

What should we test?

  • green build

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@filipefurtad0 filipefurtad0 added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label May 17, 2024
@filipefurtad0 filipefurtad0 self-assigned this May 17, 2024
@filipefurtad0
Copy link
Contributor Author

I'm surprised about this build fail, as the PR does not touch any of this code...
Only reference I've found is this PR: #5935

@sigmundpetersen
Copy link
Contributor

Seems there's a fix in #12490 , don't know why it started failing though 🤷

@filipefurtad0
Copy link
Contributor Author

Seems there's a fix in #12490 , don't know why it started failing though 🤷

Thank you for pointing it out @sigmundpetersen 🙏 I've added the blocked label here.

@filipefurtad0 filipefurtad0 force-pushed the update_paypal_checkout_system_spec branch from eb1ff44 to 818c030 Compare May 21, 2024 16:37
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mkllnk mkllnk merged commit 9d453a8 into openfoodfoundation:master May 22, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants