Strip # from referer url which which is malformed #2267
Conversation
|
thanks @dan1d ! Do we have any clue on why the URI is malformed? cc/ @sauloperez |
|
|
||
| def parsed_referer_uri | ||
| return @parsed_referer_uri if @parsed_referer_uri | ||
| referer_url = request.referer.gsub("#", '') |
There was a problem hiding this comment.
watch out, Rubocop (in Code Climate) is asking you to use #delete.
There was a problem hiding this comment.
Yes, I should have run rubocop before commiting. Should I make a new commit with the changes required by rubocop ?
I will start doing that on others PR's.
There was a problem hiding this comment.
It's up to you but normally for these single-commit PRs I just amend the commit where I added the change and I force the git push.
There was a problem hiding this comment.
Yes, I should have run rubocop before commiting.
The earlier you get feedback from Rubocop the better. That's why I strongly recommend to integrate it with your editor.
There was a problem hiding this comment.
Thanks, I'll integrate it with Visual Code, I've switched to it recently 👍
I've force pushed the changes with the single commit.
|
Hi @enricostano, I don't have a clue where this URL comes from, I'm new to the project but I'm assuming that the first "#" is the angular one and the last "#" is used as fragment identifier maybe ?, I'll dig a bit more but I don't really know If I will find the answer. |
|
Thanks a lot for your help @dan1d ! keep it up 💪 ! Just out of curosity, how did you find about OFN? |
- Cache url parsing call as it is used by other methods.
|
@sauloperez I was looking around on https://www.codetriage.com and this repository showed up on the third page I think, saw the project name, read the description and I liked the project, then I saw the long list of issues, so I'm here triying to help and contribute. |
|
Welcome @dan1d ! We really appreciate your contribution, as you see we still have a lot to do but we are clarifying processes an cleaning up old issues step by step :-) We just sent you an invitation to our Slack, if you want to get more involved in the OFN project there are opportunities! Let's talk there and meet with the team :-) |
|
Hi @dan1d 😄 |
|
Hi @daniellemoorhead I didn't have a chance yet, I'll figure it out this weekend which I should be free 👍 |
|
Hiya @dan1d...just checking in...
How's it going solving this ☝️ #tidyingupthedeliverytrain |
|
Closing this for now and moving the issue back into dev ready. @dan1d if you get a chance to come back and finish this then go right ahead and reopen the PR. Cheers 😄 |
What? Why?
Closes #2251 as it correctly parses the url sent on the referer header, the error on #2251 comes from the url having 2 different "# #" in the url:
https://alpha.katuma.org/shops#/?query=grup%20de%20consum%20la%20panarra&show_closed=1#grup-de-consum-la-panarra
It also caches the parsed uri on an instance variable so it could be used by another method that is also parsing the url.
What should we test?
Request referer #2251
curl --request GET
--header 'X-Csrf-Token: OLie+WlEahxpXGW5i+yTRNgVR+ONVsZkgE/dzFHNNXQ='
--header 'Accept-Encoding: gzip, deflate'
--header 'Cookie: [FILTERED]'
--header 'Accept: application/json, text/javascript, /'
--header 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/601.7.8 (KHTML, like Gecko) Version/9.1.3 Safari/537.86.7'
--header 'Referer: https://alpha.katuma.org/shops#/?query=grup%20de%20consum%20la%20panarra&show_closed=1#grup-de-consum-la-panarra'
--header 'Accept-Language: ca-es'
--header 'X-Requested-With: XMLHttpRequest'
'https://alpha.katuma.org/enterprises/12/relatives.json'