New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscription emails for customer should not link to order page if customer has no user account #2624
Subscription emails for customer should not link to order page if customer has no user account #2624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
@kristinalim I think you can decide what to do with the two tiny details raised above and move to test ready afterwards. |
f91f1d4
to
029679f
Compare
I made the change, and also squashed a local change I hadn't pushed (oops! 😟) which corrects Checks all good. Moving this to Test Ready now. |
I rechecked, all looks good. |
Using a helper for this, but this can be changed to look up a translation key.
The order link should not be provided if the order does not have an associated user account.
029679f
to
f844236
Compare
@luisramos0 Eep. 😁 I updated the method doc comment already. #2624 (comment) |
Staged on https://staging1.openfood.com.au/. |
Testing notes All three scenarios were behaving correctly. https://docs.google.com/document/d/13HFUszOoEyvNqdBlefMZ5K0haXj28iMiKJaLPkxXPF4/edit# |
What? Why?
Closes #2534
Updates subscription-related emails for customers, removing link to order page for customers who do not have a user account. Adds custom text for placement emails for this scenario.
What should we test?
For below, make sure that the OFN instance is already configured for Stripe integration.
The following should also be set up for the shop:
There are three types of subscription emails affected by this PR:
And three scenarios that should be tested:
Scenario 1: Customer has no associated user account
(AFAIK, there is no way for a customer with no user account to receive the SO failed payment for the subscription. I will ask and will update this when I get info.)
Scenario 2: Customer has user account, and shop is configured to allow customer to edit placed orders
(Change enterprise setting: Shop Preferences > Change Orders > "Customers can change / cancel orders while OC is open")
Scenario 3: Customer has user account, but shop is configured to restrict customer from editing placed orders
(Change enterprise setting: Shop Preferences > Change Orders > "Placed orders cannot be changed / cancelled")
Release notes
Changelog Category: Fixed