3217 [Enterprise Fee Summary] Move setup code in tests to factories #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristinalim
changed the title
We should not presume what is not default for an enterprise fee object.
kristinalim
force-pushed
the
feature-enterprise_fees_report-move_setup_to_factories
branch
from
eef993f
to
73e15c1
Compare
luisramos0
approved these changes
Jan 14, 2019
There was a problem hiding this comment.
Awesome @kristinalim we finally have /spec/factories/ 🎉
It's also good you are just adding new stuff, moving things from factories.rb to here will be better done after v2 :-)
I approve the PR, please follow my suggestions below if you agree, otherwise ignore.
mkllnk
approved these changes
Jan 15, 2019
|
Thanks for your feedback, @luisramos0! I renamed the files in
|
Make these follow the "#{SINGULAR_OBJECT}_factory.rb" convention.
kristinalim
force-pushed
the
feature-enterprise_fees_report-move_setup_to_factories
branch
from
d2ac046
to
2e14251
Compare
|
awesome, ready for testing. |
|
And it's a |
|
ah, yes, thanks for the heads up @sigmundpetersen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move setup code in Enterprise Fee Summary tests to factories.
What? Why?
Closes #3217
This cleans up the code, and allows customization and reuse of setup logic in the tests.
What should we test?
No user-observable changes expected.
Release notes
Changelog Category: Added
Dependencies
This requires #3115 to be merged to the transitional branch first.