Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump spring from 1.1.3 to 1.7.2 #3324

Merged
merged 1 commit into from Jan 16, 2019
Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps spring from 1.1.3 to 1.7.2.

Changelog

Sourced from spring's changelog.

1.7.2

  • Use Spring.failsafe_thread to prevent threads from aborting process due to Thread.abort_on_exception when set to true

1.7.1

  • Specify absolute path to spring binfile when starting the server
    (#478)
  • Time out after 10 seconds if starting the spring server doesn't work
    (maybe related to #480, #479)
  • Prevent infinite boot loop when trying to restart the spring server
    due to client/server version mismatch (related to #479)

1.7.0

  • Auto-restart server when server and client versions do not match
  • Add spring server command to explicitly start a Spring server
    process in the foreground, which logging to stdout. This will be
    useful to those who want to run spring more explicitly, but the real
    impetus was to enable running a spring server inside a Docker
    container.
  • Numerous other tweaks to better support running Spring inside
    containers (see
    https://github.com/jonleighton/spring-docker-example)

1.6.4

  • Fix incompatibility with RubyGems 2.6.0.

1.6.3

  • Fix problem with using Bundler 1.11 with a custom BUNDLE_PATH (#456)

1.6.2

  • Fix problems with the implementation of the new "Running via Spring preloader"
    message (see #456, #457)
  • Print "Running via Spring preloader" message to stderr, not stdout

1.6.1

  • support replaced backtraces / backtraces with only line and number

1.6.0

  • show when spring is used automatically to remind people why things might fail, disable with Spring.quiet = true

1.5.0

  • Make the temporary directory path used by spring contain the UID of the process
... (truncated)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

Bumps [spring](https://github.com/rails/spring) from 1.1.3 to 1.7.2.
- [Release notes](https://github.com/rails/spring/releases)
- [Changelog](https://github.com/rails/spring/blob/master/CHANGELOG.md)
- [Commits](rails/spring@v1.1.3...v1.7.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@luisramos0
Copy link
Contributor

I'll give this a try.

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not using spring, but trust you to test it. :-)

@luisramos0
Copy link
Contributor

luisramos0 commented Jan 16, 2019

It's still working! Can be upgraded.

Some tests are failing if running with spring with this error (this happens with both 1.1.3 and 1.7.2 versions):

> 
> > The factory_girl gem has been deprecated and has been replaced by factory_bot. Please switch to factory_bot as soon as possible.
> > Run options: exclude {:skip=>true, :future=>true, :to_figure_out=>true}
> > 
> >   1) BillablePeriod ensure_correct_adjustment when no adjustment currently exists creates an adjustment on the given order
> >      Failure/Error: Unable to find matching line from backtrace
> > 
> >      SystemStackError:
> >        stack level too deep
> > 

Looks like it's related to FactoryGirl but I am not sure.
Spree moves from FactoryGirl to FactoryBot in v3.5 😭

Anyway, we can move spring to 1.7.2

@luisramos0
Copy link
Contributor

just changing a dependency used in local testing. pr-no-test so ready to go.

@sauloperez sauloperez merged commit e557e06 into master Jan 16, 2019
@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/spring-1.7.2 branch January 16, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants