[Headless Chrome] Fix datepicker interactions in bulk_order_management_spec #3343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Oh no, I fixed that already in #3325. I thought you knew, because you reviewed that. Well, your solution mimics how most people probably use the datepicker. |
|
Ah, I thought that was merged before I saw the failing test come up on another build. Got my branches crossed 🙈 |
|
I don't think they're mutually exclusive..? |
mkllnk
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Fixes another test for #2469
This one was pretty nasty. I thought maybe headless chrome just really didn't like datepickers, but when I booted the app and tried inputting the dates the way we were doing it (as text), the orders didn't load well for me either. Anyway, I've updated the spec so it correctly opens the datepicker and clicks on the actual dates it needs to as if it were a user, and now it's green. 🎉
What should we test?
No testing. The new failing test in
bulk_order_management_spec.rbshould be green.