Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spree Upgrade] Fix translation missing in order confirmation email subject and bring cancel email to ofn #3695

Merged

Conversation

Projects
None yet
4 participants
@luisramos0
Copy link
Contributor

commented Apr 4, 2019

What? Why?

Closes #3696 and brings cancel email from spree to ofn!
Cancelation email has the normal ofn style now, see below!

There's more todo... for example, use lazy lookup translation keys in order confirmation emails. For next time.

What should we test?

Re order confirmation email:
Before:
Screenshot 2019-04-04 at 12 29 26

After:
Screenshot 2019-04-04 at 12 34 55

Re cancel email:
Before:
Screenshot 2019-04-04 at 12 29 04

After:
Screenshot 2019-04-04 at 12 29 09

Release notes

Using 2-0-stable as default dev branch now! And this one deserves release notes.

Changelog Category: Fixed
The order cancelation email is not styled like all other emails.

@luisramos0 luisramos0 self-assigned this Apr 4, 2019

@luisramos0 luisramos0 changed the title 2 0 emails transl [Spree Upgrade] Fix translation missing in order confirmation email subject and bring cancel email to ofn Apr 4, 2019

@luisramos0 luisramos0 force-pushed the luisramos0:2-0-emails-transl branch from 5417175 to cf3b230 Apr 4, 2019

Fix specs testing order cancelation email. The email template now nee…
…ds a order distributor for the signoff part
@sauloperez

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

Using 2-0-stable as default dev branch now!

🤘

@sauloperez
Copy link
Contributor

left a comment

👏

@mkllnk

mkllnk approved these changes Apr 13, 2019

Copy link
Member

left a comment

Yay!

@RachL RachL added pr-staged-es and removed pr-staged-es labels Apr 15, 2019

@RachL RachL self-assigned this Apr 16, 2019

@RachL RachL added the pr-staged-fr label Apr 16, 2019

@luisramos0

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

@RachL I deployed this manually in staging FR ;-)

@RachL

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

All good to go!

image

image

@luisramos0 can you refresh my memory: how is the language picked up in the emails? I was using the platform in english so I expected emails in english.

@RachL RachL removed the pr-staged-fr label Apr 16, 2019

@luisramos0

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

that would be a bug in multilanguage confirmation email @RachL
I switched to English and bought something and got an English email.
Was the checkout done in English? That would be a problem. Can you try again? Are you sure you didnt visit a French page on another browser tab for example?

@luisramos0

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

To answer your question, it's from the user.locale stored in the DB.
You user does not have a locale selected, are you sure you selected English?

email                | locale
------------------------------------+--------
 rachel.arnould@openfoodfrance.org  | en_GB
 rachel.arnould@protonmail.com      | en_GB
 rachel.arnould+shipping2@gmail.com | fr
 rachel.arnould+shipping@gmail.com  | en_GB
 rachel.arnould@gmail.com           |
@luisramos0

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

anyway, it will be a new issue if there's a problem. merging this one now.

@luisramos0 luisramos0 merged commit 67a7e26 into openfoodfoundation:2-0-stable Apr 16, 2019

1 check passed

semaphoreci The build passed on Semaphore.
Details

@luisramos0 luisramos0 deleted the luisramos0:2-0-emails-transl branch Apr 16, 2019

@RachL

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

@luisramos0 yes I will keep an eye on this, thanks for the rules ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.