[Spree Upgrade] Fix translation missing in order confirmation email subject and bring cancel email to ofn

[luisramos0]

What? Why?

Closes #3696 and brings cancel email from spree to ofn!
Cancelation email has the normal ofn style now, see below!

There's more todo... for example, use lazy lookup translation keys in order confirmation emails. For next time.

What should we test?

Re order confirmation email:
Before:

After:

Re cancel email:
Before:

After:

Release notes

Using 2-0-stable as default dev branch now! And this one deserves release notes.

Changelog Category: Fixed
The order cancelation email is not styled like all other emails.

[sauloperez]

Using 2-0-stable as default dev branch now!

🤘

[sauloperez]

👏

[mkllnk]

[luisramos0]

@RachL I deployed this manually in staging FR ;-)

[RachL]

All good to go!

@luisramos0 can you refresh my memory: how is the language picked up in the emails? I was using the platform in english so I expected emails in english.

[luisramos0]

that would be a bug in multilanguage confirmation email @RachL
I switched to English and bought something and got an English email.
Was the checkout done in English? That would be a problem. Can you try again? Are you sure you didnt visit a French page on another browser tab for example?

[luisramos0]

To answer your question, it's from the user.locale stored in the DB.
You user does not have a locale selected, are you sure you selected English?

email                | locale
------------------------------------+--------
 rachel.arnould@openfoodfrance.org  | en_GB
 rachel.arnould@protonmail.com      | en_GB
 rachel.arnould+shipping2@gmail.com | fr
 rachel.arnould+shipping@gmail.com  | en_GB
 rachel.arnould@gmail.com           |

[luisramos0]

anyway, it will be a new issue if there's a problem. merging this one now.

[RachL]

@luisramos0 yes I will keep an eye on this, thanks for the rules ;)