-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove option types menu entry #4397
Remove option types menu entry #4397
Conversation
We keep the underlying data structures because option types and option values are used internally to keep units in OFN: weight, volume and items, but otherwise, custom option types are no longer possible in OFN
c7d2255
to
42cd9a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting product review @lin-d-hop @RachL
@sauloperez I'm not sure what the product review is about. If I understand clearly, we are removing something that is anyway not working. If so, it's a good news and this PR should go forward. |
hello @RachL I can clarify. original slack message: The product review required here is: "this is dead/broken feature zone, correct? shout if you think these pages cannot be removed for some reason" :-) |
Ah ok. Yes this is dead feature as Sigmund has answered before :) |
Hi @luisramos0, Logged in as superadmin, the "custom option types" submenu dissappeaers, when staging this PR. Before: So, all good -> moving to Ready to Go! |
What? Why?
It's not possible to create custom option types in OFN and use them in products/variants. In OFN we have static list of option types that can be used in products: weight, volume and items.
This page is a legacy spree page for when the option types could be associated with products.
What should we test?
We are only removing the menu entry, make sure the menu entry is not there under the Products menu.
Release notes
Changelog Category: Removed
Remove Option Types menu entry, this is a legacy feature from Spree that is not usable in OFN.