Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove option types menu entry #4397

Merged

Conversation

luisramos0
Copy link
Contributor

What? Why?

It's not possible to create custom option types in OFN and use them in products/variants. In OFN we have static list of option types that can be used in products: weight, volume and items.
This page is a legacy spree page for when the option types could be associated with products.

What should we test?

We are only removing the menu entry, make sure the menu entry is not there under the Products menu.

Release notes

Changelog Category: Removed
Remove Option Types menu entry, this is a legacy feature from Spree that is not usable in OFN.

@luisramos0 luisramos0 self-assigned this Oct 23, 2019
We keep the underlying data structures because option types and option values are used internally to keep units in OFN: weight, volume and items, but otherwise, custom option types are no longer possible in OFN
Copy link
Contributor

@sauloperez sauloperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting product review @lin-d-hop @RachL

@RachL
Copy link
Contributor

RachL commented Oct 28, 2019

@sauloperez I'm not sure what the product review is about. If I understand clearly, we are removing something that is anyway not working. If so, it's a good news and this PR should go forward.
If it was not the case, this conversation should have occurred in discourse first, before any PR would have been submitted.

@luisramos0
Copy link
Contributor Author

luisramos0 commented Oct 28, 2019

hello @RachL I can clarify.

original slack message:
https://openfoodnetwork.slack.com/archives/CG7NJ966B/p1571695576075000

The product review required here is: "this is dead/broken feature zone, correct? shout if you think these pages cannot be removed for some reason" :-)

@RachL
Copy link
Contributor

RachL commented Oct 28, 2019

Ah ok. Yes this is dead feature as Sigmund has answered before :)

@filipefurtad0
Copy link
Contributor

filipefurtad0 commented Nov 1, 2019

Hi @luisramos0,

Logged in as superadmin, the "custom option types" submenu dissappeaers, when staging this PR. Before:

crop_Screenshot at 2019-11-01 11-26-06

and after:
crop_Screenshot at 2019-11-01 11-48-00

So, all good -> moving to Ready to Go!
Thank you :-)

@luisramos0 luisramos0 merged commit a947d8d into openfoodfoundation:master Nov 1, 2019
@luisramos0 luisramos0 deleted the delete_option_types_page branch November 1, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants