Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added translation key to locale/en.yml for backoffice admin payment #5698

Merged
merged 2 commits into from Jul 30, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jun 29, 2020

What? Why?

Closes #5575
When placing orders in the backoffice, and selecting Paypal as payment option, the "No Payment Via Admin Backend" is not translated.

What should we test?

Place an order in the backoffice and choose Paypal as the payment type. "No Payment Via Admin Backend" should be translated in any non-English instance. I was unable to test the translation locally as Paypal is not available as a payment option in the default setup. Please test and request changes as needed.

Release notes

Hint about PayPal payments in the backoffice can be translated.

Changelog Category: Added

@sigmundpetersen sigmundpetersen assigned ghost Jun 29, 2020
Copy link
Contributor

@luisramos0 luisramos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for one more!

Can you please follow convention and convert to lazy lookup? Thanks.

basically
t('.no_payment_via_admin_backend') with the dot
and then en.yml on line 3333 add paypal: there's stripe there already.

@ghost
Copy link
Author

ghost commented Jul 6, 2020

Thanks for one more!

Can you please follow convention and convert to lazy lookup? Thanks.

basically
t('.no_payment_via_admin_backend') with the dot
and then en.yml on line 3333 add paypal: there's stripe there already.

busy but hoping to get back to this issue this week. @luisramos0 our en.yml line numbers seem to be mismatched again. I will add the lazy loading, but didn't see a reference to stripe, not sure if where I had placed the key in en.yml is sufficient or not.

@luisramos0
Copy link
Contributor

luisramos0 commented Jul 6, 2020

ok 👍
master is the reference:

stripe:
error_saving_payment: Error saving payment
submitting_payment: Submitting payment...

@ghost ghost requested a review from luisramos0 July 20, 2020 04:11
config/locales/en.yml Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jul 20, 2020

Happy to change, but this message did come from the issue opened by @filipefurtad0, so I went with that one.

Screen Shot 2020-07-20 at 5 37 48 pm

Copy link
Contributor

@luisramos0 luisramos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Robin! Yes, I was not clear, it was not required for the PR or in the issue. I just thought it would be a good opportunity to improve it. I am approving the PR as is to make it clear it is not mandatory 👍
And thanks for one more PR!

@ghost
Copy link
Author

ghost commented Jul 20, 2020

Thanks @luisramos0!

@filipefurtad0 filipefurtad0 self-assigned this Jul 30, 2020
@filipefurtad0 filipefurtad0 added the pr-staged-uk staging.openfoodnetwork.org.uk label Jul 30, 2020
@filipefurtad0
Copy link
Contributor

Hi @rmklaus12,

This looks good to be merged:

image

Thank you for adding the key, and updating the backoffice-Paypal message as well!

Moving to ready to go.

@filipefurtad0 filipefurtad0 removed the pr-staged-uk staging.openfoodnetwork.org.uk label Jul 30, 2020
@luisramos0 luisramos0 merged commit df465cf into openfoodfoundation:master Jul 30, 2020
@ghost ghost deleted the 5575-backofficepay-missing-translation branch December 17, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing translation in backoffice Payments
4 participants