-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added translation key to locale/en.yml for backoffice admin payment #5698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for one more!
Can you please follow convention and convert to lazy lookup? Thanks.
basically
t('.no_payment_via_admin_backend') with the dot
and then en.yml on line 3333 add paypal: there's stripe there already.
busy but hoping to get back to this issue this week. @luisramos0 our en.yml line numbers seem to be mismatched again. I will add the lazy loading, but didn't see a reference to stripe, not sure if where I had placed the key in en.yml is sufficient or not. |
ok 👍 openfoodnetwork/config/locales/en.yml Lines 3331 to 3333 in d2adcd2
|
…nd added lazy loading
Happy to change, but this message did come from the issue opened by @filipefurtad0, so I went with that one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Robin! Yes, I was not clear, it was not required for the PR or in the issue. I just thought it would be a good opportunity to improve it. I am approving the PR as is to make it clear it is not mandatory 👍
And thanks for one more PR!
Thanks @luisramos0! |
Hi @rmklaus12, This looks good to be merged: Thank you for adding the key, and updating the backoffice-Paypal message as well! Moving to ready to go. |
What? Why?
Closes #5575
When placing orders in the backoffice, and selecting Paypal as payment option, the "No Payment Via Admin Backend" is not translated.
What should we test?
Place an order in the backoffice and choose Paypal as the payment type. "No Payment Via Admin Backend" should be translated in any non-English instance. I was unable to test the translation locally as Paypal is not available as a payment option in the default setup. Please test and request changes as needed.
Release notes
Hint about PayPal payments in the backoffice can be translated.
Changelog Category: Added