Customer names in reports

[Matt-Yorkley]

What? Why?

Closes #5054, #5097

• Adds a new enterprise "Shop Preference" to allow suppliers to view customer names in reports.
• Conditionally masks relevant customer names based on the new setting

What should we test?

Enterprises can set an "allow customer names" preference in admin enterprise edit page, under "Shop Preferences". The default selection is "disabled".

The following reports need to be tested:

• Orders and distributors report (one column: Customer name)
• Bulk Co-op reports (one column: Customer name)
• Orders and Fulfillment - Order Cycle Customer Totals report (one column: Customer name)
• Enterprise Fees report
• Both Packing reports (name and first names are two columns on these ones!)

The test conditions are as follows:

• The current user manages a supplier that supplied products in some placed orders. The user should not manage the distributor enterprise the orders were placed with.
• The supplier enterprise has set the enterprise permission "add to order cycle" for a the distributor.
• The distributor enterprise has the "allow customer names" shop preference disabled.
• The (supplier enterprise) user looks at the reports listed above, and can not see customer names.
• The distributor enterprise then sets the "allow customer names" shop preference to enabled.
• The user managing the supplier can then view the reports listed below, and customer names are visible.

Release notes

Added option for distributors to allow their suppliers to see customer names in reports, for improved packing

[luisramos0]

All right!

It's a new feature, I think it's better if we get some screenshots of the new config item and of a report with and without names.

I left some comments to refactor some of the code.

The only reason why I am not approving the PR yet is that I think it should be prefers_ not preferred_?

[Matt-Yorkley]

I wanted to do a lot more here, but was told to do the minimum to cover the epic. I've updated and refactored a lot more 👍

[luisramos0]

awesome, thanks Matt. New service 👍
I think I'd still go with prefers_ but now I see it's only for readability.

[mkllnk]

I like the extraction into a service. 🌷

[filipefurtad0]

Hey @Matt-Yorkley ,

Thanks for this new feature! Had a look at the different scenarios in your test notes, and as well on the feature requests from @RachL .

Before staging this PR

• Created a profile only producer A:

• Created product B, with items in stock

• Set this producer A to act as a supplier to an enterprise, as indicated by the permissions below:
  

As a hub/enterprise manager C:

• Verified that the "allow customer names" preference does not exist on the dashboard.
• Added the product B from the supplier A to an open order cycle

As a customer D:

• visited the shop from the enterprise C (which sells the produce B from the supplier A)
• inserted the product B in the cart and checked out.

As Producer A:

• verified that the name/surname from customer D does not appear in the reports

  Orders and distributors report (one column: Customer name - appears as HIDDEN)

Bulk Co-op reports (one column: Customer name - not appearing)

Orders and Fulfillment - Order Cycle Customer Totals report (one column: Customer name - not appearing)

Enterprise Fees report

Both Packing reports (name and first names are two columns on these ones! - appears as HIDDEN)

After staging this PR

As a hub/enterprise manager C:

• Verified that the "allow customer names" preference now exists on the dashboard, and can now be set, and that it's default preference is "disabled":

As Producer A:

• verified that the reports shown above look the same, and still hide the names of customers.

As a hub/enterprise manager C:

• Enabled the "allow customer names" preference

As Producer A:

• checked all the reports again - customer names are now visible 🎉

  Orders and distributors report (one column: Customer name is visible, email is hidden)

Bulk Co-op reports (one column: Customer name - now appearing)

Orders and Fulfillment - Order Cycle Customer Totals report (one column: Customer name - not appearing)

Enterprise Fees report - customer name now visible

Both Packing reports (name and first names are two columns on these ones! - now appearing)

Awesome work! Thank you @RachL for inception and @Matt-Yorkley for implementing 💪
Ready to go.