[Bye bye Spree] Make OFN independent of all spree spec factories #5943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we need to bring from spree_core
the 3 factories I cannot figure out out to make this work again...
… stock location of the product factory
luisramos0
force-pushed
the
spree_factories
branch
2 times, most recently
from
56cb8f3
to
211f684
Compare
luisramos0
force-pushed
the
spree_factories
branch
from
211f684
to
ee158e8
Compare
We dont need the global zone
luisramos0
force-pushed
the
spree_factories
branch
from
ee158e8
to
17955e0
Compare
luisramos0
force-pushed
the
spree_factories
branch
from
17955e0
to
41d67d8
Compare
luisramos0
commented
Aug 23, 2020
| @@ -1,22 +1,10 @@ | |||
| require 'ffaker' | |||
| require 'spree/testing_support/factories' | |||
There was a problem hiding this comment.
this is the magic of this PR: no spree factories used.
Matt-Yorkley
approved these changes
Aug 25, 2020
|
👍 I ended up running rubocop -a on spec/factories (last commit). Let's see if the build is ok. EDIT: Build is ok :-) |
sauloperez
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Relates to #4826
Move all necessary factories from spree_core to ofn.
What should we test?
A green build is enough here, only test code changed.
Release notes
Changelog Category: Changed
Brought test support code from spree so that we can make OFN independent of Spree.