[Bye bye Spree] Make OFN independent of all spree spec factories

engines/order_management/spec/services/order_management/stock/estimator_spec.rb

@@ -5,7 +5,7 @@
 module OrderManagement
   module Stock
     describe Estimator do
-      let!(:shipping_method) { create(:shipping_method, zones: [Spree::Zone.global] ) }
+      let!(:shipping_method) { create(:shipping_method, zones: [create(:zone)] ) }
       let(:package) { build(:stock_package_fulfilled) }
       let(:order) { package.order }
       subject { Estimator.new(order) }

spec/controllers/api/shipments_controller_spec.rb

@@ -29,7 +29,7 @@
     let(:current_api_user) { build(:admin_user) }
     let!(:order) { shipment.order }
     let(:order_ship_address) { create(:address) }
-    let!(:stock_location) { create(:stock_location_with_items) }
+    let!(:stock_location) { Spree::StockLocation.first || create(:stock_location) }
     let!(:variant) { create(:variant) }
     let(:params) do
       { quantity: 2,

spec/factories.rb

@@ -1,22 +1,10 @@
 require 'ffaker'
-require 'spree/testing_support/factories'
-
-# http://www.rubydoc.info/gems/factory_bot/file/GETTING_STARTED.md
-#
-# The spree_core gem defines factories in several files. For example:
-#
-# - lib/spree/core/testing_support/factories/calculator_factory.rb
-#   * calculator
-#   * no_amount_calculator
-#
-# - lib/spree/core/testing_support/factories/order_factory.rb
-#   * order
-#   * order_with_totals
-#   * order_with_inventory_unit_shipped
-#   * completed_order_with_totals
-#
 
 FactoryBot.define do
+  sequence(:random_string)      { Faker::Lorem.sentence }
+  sequence(:random_description) { Faker::Lorem.paragraphs(1 + Kernel.rand(5)).join("\n") }
+  sequence(:random_email)       { Faker::Internet.email }
+
   factory :classification, class: Spree::Classification do
   end
 
@@ -97,6 +85,16 @@
     calculator { build(:calculator_per_item, preferred_amount: amount) }
 
     after(:create) { |ef| ef.calculator.save! }
+
+    trait :flat_rate do
+      transient { amount 1 }
+      calculator { build(:calculator_flat_rate, preferred_amount: amount) }
+    end
+
+    trait :per_item do
+      transient { amount 1 }
+      calculator { build(:calculator_per_item, preferred_amount: amount) }
+    end
   end
 
   factory :adjustment_metadata, class: AdjustmentMetadata do
@@ -107,35 +105,6 @@
     enterprise_role 'distributor'
   end
 
-  factory :line_item_with_shipment, parent: :line_item do
-    transient do
-      shipping_fee 3
-      shipping_method nil
-    end
-
-    after(:build) do |line_item, evaluator|
-      shipment = line_item.order.reload.shipments.first
-      if shipment.nil?
-        shipping_method = evaluator.shipping_method
-        unless shipping_method
-          shipping_method = create(:shipping_method_with, :shipping_fee, shipping_fee: evaluator.shipping_fee)
-          shipping_method.distributors << line_item.order.distributor if line_item.order.distributor
-        end
-        shipment = create(:shipment_with, :shipping_method, shipping_method: shipping_method,
-                                                            order: line_item.order)
-      end
-      line_item.target_shipment = shipment
-    end
-  end
-
-  factory :zone_with_member, parent: :zone do
-    default_tax true
-
-    after(:create) do |zone|
-      Spree::ZoneMember.create!(zone: zone, zoneable: Spree::Country.find_by(name: 'Australia'))
-    end
-  end
-
   factory :producer_property, class: ProducerProperty do
     value 'abc123'
     producer { create(:supplier_enterprise) }
@@ -150,76 +119,9 @@
     bill_address { create(:address) }
   end
 
-  # A card that has been added to the user's profile and can be re-used.
-  factory :stored_credit_card, parent: :credit_card do
-    gateway_customer_profile_id "cus_F2T..."
-    gateway_payment_profile_id "card_1EY..."
-  end
-
-  factory :stripe_payment_method, class: Spree::Gateway::StripeConnect do
-    name 'Stripe'
-    environment 'test'
-    distributors { [FactoryBot.create(:enterprise)] }
-    preferred_enterprise_id { distributors.first.id }
-  end
-
-  factory :stripe_sca_payment_method, class: Spree::Gateway::StripeSCA do
-    name 'StripeSCA'
-    environment 'test'
-    distributors { [FactoryBot.create(:stripe_account).enterprise] }
-    preferred_enterprise_id { distributors.first.id }
-  end
-
   factory :stripe_account do
     enterprise { FactoryBot.create(:distributor_enterprise) }
     stripe_user_id "abc123"
     stripe_publishable_key "xyz456"
   end
 end
-
-FactoryBot.modify do
-  factory :address do
-    state { Spree::State.find_by name: 'Victoria' }
-    country { Spree::Country.find_by name: 'Australia' || Spree::Country.first }
-  end
-
-  factory :credit_card do
-    cc_type 'visa'
-  end
-
-  factory :payment do
-    transient do
-      distributor {
-        order.distributor ||
-          Enterprise.is_distributor.first ||
-          FactoryBot.create(:distributor_enterprise)
-      }
-    end
-    payment_method { FactoryBot.create(:payment_method, distributors: [distributor]) }
-  end
-
-  factory :payment_method do
-    distributors { [Enterprise.is_distributor.first || FactoryBot.create(:distributor_enterprise)] }
-  end
-
-  factory :option_type do
-    # Prevent inconsistent ordering in specs when all option types have the same (0) position
-    sequence(:position)
-  end
-
-  factory :stock_location, class: Spree::StockLocation do
-    # keeps the test stock_location unique
-    initialize_with { DefaultStockLocation.find_or_create }
-
-    # Ensures the name attribute is not assigned after instantiating the default location
-    transient { name 'default' }
-
-    # sets the default value for variant.on_demand
-    backorderable_default false
-  end
-
-  factory :shipping_category, class: Spree::ShippingCategory do
-    initialize_with { DefaultShippingCategory.find_or_create }
-    transient { name 'Default' }
-  end
-end

spec/factories/address_factory.rb

@@ -1,5 +1,18 @@
-FactoryBot.modify do
-  factory :address do
+FactoryBot.define do
+  factory :address, aliases: [:bill_address, :ship_address], class: Spree::Address do
+    firstname 'John'
+    lastname 'Doe'
+    company 'Company'
+    address1 '10 Lovely Street'
+    address2 'Northwest'
+    city 'Herndon'
+    zipcode '20170'
+    phone '123-456-7890'
+    alternative_phone '123-456-7899'
+
+    state { Spree::State.find_by name: 'Victoria' }
+    country { Spree::Country.find_by name: 'Australia' || Spree::Country.first }
+
     trait :randomized do
       firstname { Faker::Name.first_name }
       lastname { Faker::Name.last_name }

spec/factories/adjustment_factory.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :adjustment, class: Spree::Adjustment do
+    association(:adjustable, factory: :order)
+    amount 100.0
+    label 'Shipping'
+    association(:source, factory: :shipment)
+    eligible true
+  end
+end

spec/factories/calculated_adjustment_factory.rb

@@ -3,21 +3,3 @@
     preferred_amount { generate(:calculator_amount) }
   end
 end
-
-FactoryBot.modify do
-  attach_calculator_traits = proc do
-    trait :flat_rate do
-      transient { amount 1 }
-      calculator { build(:calculator_flat_rate, preferred_amount: amount) }
-    end
-
-    trait :per_item do
-      transient { amount 1 }
-      calculator { build(:calculator_per_item, preferred_amount: amount) }
-    end
-  end
-
-  factory :payment_method, &attach_calculator_traits
-  factory :shipping_method, &attach_calculator_traits
-  factory :enterprise_fee, &attach_calculator_traits
-end

spec/factories/calculator_factory.rb

@@ -1,4 +1,12 @@
 FactoryBot.define do
+  factory :calculator, class: Spree::Calculator::FlatRate do
+    after(:create) { |c| c.set_preference(:amount, 10.0) }
+  end
+
+  factory :no_amount_calculator, class: Spree::Calculator::FlatRate do
+    after(:create) { |c| c.set_preference(:amount, 0) }
+  end
+
   sequence(:calculator_amount)
   factory :calculator_per_item, class: Calculator::PerItem do
     preferred_amount { generate(:calculator_amount) }

spec/factories/country_factory.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :country, class: Spree::Country do
+    iso_name 'UNITED STATES'
+    name 'United States of America'
+    iso 'US'
+    iso3 'USA'
+    numcode 840
+  end
+end

spec/factories/credit_card_factory.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+# allows credit card info to be saved to the database which is needed for factories to work properly
+class TestCard < Spree::CreditCard
+  def remove_readonly_attributes(attributes) attributes; end
+end
+
+FactoryBot.define do
+  factory :credit_card, class: TestCard do
+    verification_value 123
+    month 12
+    year { Time.zone.now.year + 1 }
+    number '4111111111111111'
+
+    cc_type 'visa'
+  end
+
+  # A card that has been added to the user's profile and can be re-used.
+  factory :stored_credit_card, parent: :credit_card do
+    gateway_customer_profile_id "cus_F2T..."
+    gateway_payment_profile_id "card_1EY..."
+  end
+end

spec/factories/inventory_unit_factory.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :inventory_unit, class: Spree::InventoryUnit do
+    variant
+    order
+    state 'on_hand'
+    association(:shipment, factory: :shipment, state: 'pending')
+  end
+end

spec/factories/line_item_factory.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :line_item, class: Spree::LineItem do
+    quantity 1
+    price { BigDecimal('10.00') }
+    order
+    variant
+  end
+
+  factory :line_item_with_shipment, parent: :line_item do
+    transient do
+      shipping_fee 3
+      shipping_method nil
+    end
+
+    after(:build) do |line_item, evaluator|
+      shipment = line_item.order.reload.shipments.first
+      if shipment.nil?
+        shipping_method = evaluator.shipping_method
+        unless shipping_method
+          shipping_method = create(:shipping_method_with, :shipping_fee, shipping_fee: evaluator.shipping_fee)
+          shipping_method.distributors << line_item.order.distributor if line_item.order.distributor
+        end
+        shipment = create(:shipment_with, :shipping_method, shipping_method: shipping_method,
+                                                            order: line_item.order)
+      end
+      line_item.target_shipment = shipment
+    end
+  end
+end

spec/factories/options_factory.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :option_value, class: Spree::OptionValue do
+    name 'Size'
+    presentation 'S'
+    option_type
+  end
+
+  factory :option_type, class: Spree::OptionType do
+    name 'foo-size'
+    presentation 'Size'
+
+    # Prevent inconsistent ordering in specs when all option types have the same (0) position
+    sequence(:position)
+  end
+end