Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ofBaseClass Documentation. #3338

Merged
merged 7 commits into from
Nov 27, 2014

Conversation

bakercp
Copy link
Member

@bakercp bakercp commented Oct 21, 2014

Docs for lots of base classes.

@bakercp bakercp changed the title Documentation for ofVideoGrabber's base classes. Documentation for lots of base classes. Oct 21, 2014
@bakercp
Copy link
Member Author

bakercp commented Oct 21, 2014

@admsyn Could I convince you to document the base audio classes? It shouldn't take too long :)

@mikewesthad, @brannondorsey and others could I convince you to give it all a read for accuracy, typos, etc?

@mikewesthad
Copy link
Member

Awesome - will do

@admsyn
Copy link
Member

admsyn commented Oct 21, 2014

Sure can :)

@bakercp bakercp changed the title Documentation for lots of base classes. ofBaseClass Documentation. Oct 21, 2014
@bakercp
Copy link
Member Author

bakercp commented Oct 21, 2014

BTW, These base class docs will be automatically filled in for subclass methods by doxygen, so in the future, we can remove any redundant documentation for those subclass methods...

@mikewesthad
Copy link
Member

@bakercp, PR'd you a few fixes bakercp#21

@mikewesthad
Copy link
Member

And, of course, ++ for the documentation push

Minor grammar/code example fixes for documentation
@bakercp
Copy link
Member Author

bakercp commented Nov 25, 2014

@HalfdanJ Can you take a look at this? I'd like to get it merged before it gets stale :)

@HalfdanJ HalfdanJ self-assigned this Nov 26, 2014
@HalfdanJ
Copy link
Member

Thank you, i will merge it into my documentation changes. I've just asked out on the mailling list how i should proceed with merging all the changes into master.

@bilderbuchi
Copy link
Member

Why not merge it directly into master now? It's ready, and then it would already be in master, and not delayed until you merge your changes in. Also, less diff from master for your PR branch, so less potential of conflicts.

bakercp added a commit that referenced this pull request Nov 27, 2014
@bakercp bakercp merged commit b172eb8 into openframeworks:master Nov 27, 2014
@bakercp bakercp deleted the documentation-baseclasses branch November 27, 2014 16:35
@bakercp
Copy link
Member Author

bakercp commented Nov 27, 2014

done.

@kylemcdonald kylemcdonald mentioned this pull request Nov 1, 2015
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants