Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ofxiOSVideoPlayer is now using ofAVFoundationPlayer #3662

Closed
wants to merge 1 commit into from
Closed

ofxiOSVideoPlayer is now using ofAVFoundationPlayer #3662

wants to merge 1 commit into from

Conversation

julapy
Copy link
Member

@julapy julapy commented Feb 19, 2015

  • removed old AVFoundationVideoPlayer classes.
  • created a typedef for ofxiOSVideoPlayer to point to ofAVFoundationPlayer
  • updated ios/moviePlayerExample

@julapy
ofxiOSVideoPlayer is now using ofAVFoundationPlayer
fbf4082 
- removed old AVFoundationVideoPlayer classes.
- created a typedef for ofxiOSVideoPlayer to point to
ofAVFoundationPlayer
- updated ios/moviePlayerExample
@ofTheo
Copy link
Member

ofTheo commented May 14, 2015

would love to get this in. maybe its already been merged with the more recent PRs?

@pizthewiz
Copy link
Member

It might just need a rebase - in case it is helpful, I've found this guide from the edX team helpful: How to Rebase a Pull Request.

@ofTheo
Copy link
Member

ofTheo commented Jun 30, 2015

can we close this @julapy @danoli3 - or do we still need to get this in?
thanks!!

@julapy
Copy link
Member Author

julapy commented Jun 30, 2015

this is done now

Sent from my Nokia 3210

On 30 Jun 2015, at 4:20 pm, Theodore Watson notifications@github.com wrote:

can we close this @julapy @danoli3 - or do we still need to get this in?
thanks!!

—
Reply to this email directly or view it on GitHub.

@bilderbuchi
Copy link
Member

thanks!

@danoli3
Copy link
Member

danoli3 commented Jul 1, 2015

Awesome!

Sent from my iPhone

On 1 Jul 2015, at 1:03 am, Christoph Buchner notifications@github.com wrote:

thanks!

—
Reply to this email directly or view it on GitHub.

@julapy julapy deleted the ios-use-unified-videoplayer branch January 15, 2016 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@julapy @ofTheo @pizthewiz @bilderbuchi @danoli3