-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make smaller Electron apps on OS X and iOS #63
Comments
this sounds reasonable. does the same thing happen when you run npm run build:osx on osx? I've been curious if there are differences between the platforms with regards to symlinks. If this is an issue with electron binary downloads (which our project is based off of) can you post an issue upstream at electron: https://github.com/atom/electron for example, I saw this as part of their build process but didn't track exactly what it's doing: https://github.com/atom/electron/blob/master/tools/mac/create-framework-subdir-symlinks.sh if it's not a problem with electron, it might be an issue with electron packager? https://github.com/maxogden/electron-packager (for example, the osx 10.8 problem was an upstream issue with unzipping empty folders, it's useful to track down which module is causing the problem, sometimes we can work our way around it.) |
i'm just checking this and the problem is not in the linux server which is generating the package correctly with those folders as soft links but in the zip file. zip doesn't support soft links, file permissions... that's why the linux downloads use tar.gz. When compressing the generated folder with zip it converts those links into real folders. should we switch to tar.gz? i guess in osx it shouldn't be a problem no? |
ah that makes sense. Tar.gz should be fine ! Also, it looks like there might be a flag for symlinks? http://serverfault.com/questions/265675/how-can-i-zip-compress-a-symlink |
oh, ok i've added the symlinks flag and am regenerating the nightlies now, if that doesn't work i'll change it to tar.gz |
i think it's fixed now: http://ci.openframeworks.cc/versions/nightly/ it's slightly bigger than 97Mb but that could be related to the newer version of nodejs, the fodlers are now symlinks if you want to double check just in case i'm missing something? |
looks good! I'm going to look at the icons now but the package seems pretty good to me |
ok i'm going to close this then |
great detective work, thanks! |
The "Electron Framework" is duplicated 3x for some reason. We can replace two of these with symlinks like this:
Here is the Project Generator before:
And after:
This makes the .zip for OS X go from 224MB to 172MB.
The text was updated successfully, but these errors were encountered: