Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are shared objects not packaged with the AAR? #5

Closed
pietroglyph opened this issue Mar 25, 2020 · 1 comment
Closed

Why are shared objects not packaged with the AAR? #5

pietroglyph opened this issue Mar 25, 2020 · 1 comment

Comments

@pietroglyph
Copy link

Right now you instruct users to copy libOpenCvNative.so to a specific directory on the device and then you load the shared object from that specific path via System.load. This adds an extra step to the setup process, and I was wondering if there was any reason you don't place the shared object under src/main/jniLibs/{ABI TRIPLE}/ where it will be automatically included in the AAR?

If there's no reason that this isn't being done then I'll go ahead and make a PR that packages the shared objects in this manner.

@Windwoes
Copy link
Member

Actually, extra work was done specifically in order to be able to load it from external storage instead of packaging it with the artifact in order to prevent the RC APK from being bloated another 10MB, which can have a significant effect on wireless ADB deploy times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants