Information drawer functionality #5251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when we drag navigatingDrawer it should change position of both compassArrow and ScaleBar too.
based on showing always or not in settings + formatting NavigatingDrawer.
|
🎉 Ta-daaa, freshly created APKs are available for f8cd5a8: arm64-android |
nirvn
commented
May 18, 2024
There was a problem hiding this comment.
@mohsenD98 , great work here, super excited to see this coming along! Some comments added.
I'm thrilled to have been able to help and can't wait to dive into the next steps! Thank you for your kind words and for taking the time to add some comments. I'm always eager to learn from your feedback and make adjustments to ensure that the code is accurate, clear, and helpful. |
Add mainBackgroundTransparentColor. Rename navigatingDrawer to informationDrawer. Move some input logic into the InformationDrawer.
Move SensorInformationView from qgisMobileApp.qml to InformationDrawer.
also add elevationProfile.visible to navigationInformationViewEnabled. because when elevationProfile is enabled, navigationInformation causes more margin. we should hide it in background.
nirvn
commented
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at improving both the style as well as the UX of the way we display positioning/navigation/sensor information on top of the main canvas.
@mohsenD98 , I've given you write access to QField's main repository, I'd recommend you update you branch to use this.