Bookmark basics #2355
Merged
Bookmark basics #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
m-kuhn
reviewed
Dec 12, 2021
m-kuhn
approved these changes
Dec 16, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements basic bookmarks display framework for QField. In action:
Peek.2021-12-12.11-58.mp4
The framework displays both project bookmarks (see in the screencast) as well as app-wide bookmarks (UI to be implemented in a different PR).
This is cool for a couple of reasons:
a/ the bookmarks are rendered as QML items, so it is always shown and not bound to canvas rendering
b/ the app-wide bookmarks will be saved across projects
A single click/tap on the bookmark throws a toaster message with the bookmark name. A double click/tap sets the map canvas extent to the bookmark extent:
Peek.2021-12-12.15-01.mp4