Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refinements to improved map canvas handlers #5176

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Apr 10, 2024

@domi4484 , aimed at fixing what you spotted.

@qfield-fairy
Copy link
Collaborator

qfield-fairy commented Apr 10, 2024

@domi4484
Copy link
Member

There are still some issues:

  • after closing the attribute form I can't move the canvas anymore
  • if I take a vertical picture it becomes horizontal when editing
  • buttons are still difficult to tap

src/qml/MapCanvas.qml Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/drawingcanvas.cpp Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/drawingcanvas.cpp Show resolved Hide resolved
@nirvn nirvn merged commit b5a8fb8 into master Apr 10, 2024
23 checks passed
@nirvn nirvn deleted the handlers_refinements branch April 10, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants