Added column showing number of recently active users to projets under OrganizationAdmin
#591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… OrganizationAdmin
suricactus
changed the title
OrganizationAdmin
suricactus
reviewed
Mar 23, 2023
docker-app/qfieldcloud/core/admin.py
Outdated
Comment on lines
1037
to
1042
| @admin.display(description=_("Active users (last 90 days)")) | ||
| def active_users(self, instance) -> int: | ||
| now = datetime.now() | ||
| three_months_ago = now - timedelta(days=90) | ||
| return len(list(instance.active_users(now, three_months_ago))) | ||
|
|
There was a problem hiding this comment.
Actually you can use org.current_subscription.active_users_count, which will do it for the last billing period, if the subscription was active and probably raise? otherwise. If the latter case we better return None, which makes the admin show -.
There was a problem hiding this comment.
And one remark, look at the page performance. If it get's 100%+ slower, probably it should not be a column in the List view, but readonly field in the edit view.
why-not-try-calmer
force-pushed
the
QF-2603_show_active_users_under_orga
branch
from
bd9ced8
to
612feb3
Compare
suricactus
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… OrganizationAdmin