Custom ReachedMaxOrganizationMembersError exception instead of generic ValidationError

[why-not-try-calmer]

No description provided.

[duke-nyuki]

Task linked: QF-2539 When trying to add a new member in organization that reached the limit show nice error instead of HTTP 500

[suricactus]

Suggested change

	class ReachedMaxOrgaMembers(Exception):
	class ReachedMaxOrganizationMembersError(ValidationError):

[suricactus]

So far I keep everything explicit without a lot of shortening. More typing, but clear explicitness.

Using ValidationError as parent, will make Django help us in some situations with automatically showing the error.

[why-not-try-calmer]

Despite my "accept commit" the thing I don't like is that it's not a validation error, and moreover should not to have to declare a status_code. That's why I refrained from sublcassing ValidationError. Can we find a middle ground? Perhaps more fine-grained than an Exception but not a subtype of ValidationError?

[suricactus]

I do agree with your objections and it is something we can look into in the future for sure. Please add a TODO comment as a reminder before the exception definition.

I would propose we keep it as a ValidationError for now, until we find a better solution, so we minimize the risk of breaking something in the code that relied on this ValidationError class.

[suricactus]

ok, second thought. Define it like the rest of exceptions in the file, but extend QFieldCloudException.

YOLO if someone relies on ValidationError subclass.

[why-not-try-calmer]

Not sure if the just added status code is correct though.

[suricactus]

You also need to fix the tests, e.g. test_max_organization_members_raises_when_adding_new_member_over_limit .