Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase stop grace period for worker wrapper #635

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Increase stop grace period for worker wrapper #635

merged 1 commit into from
Jun 7, 2023

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented Apr 30, 2023 •
edited
Loading

Let wrappers exit gracefully when scaling

  • Needs discussion and testing

@m-kuhn
Increase stop grace period for worker wrapper
8f36b71 
Let wrappers exit gracefully when scaling
@m-kuhn m-kuhn marked this pull request as draft April 30, 2023 16:55
@suricactus
Copy link
Collaborator

  • test with long running job if it is going to wait for these 15 mins (or more than the usual 10 secs)?
  • test with no job running if it exists immediatly

@suricactus suricactus self-assigned this May 2, 2023
@m-kuhn m-kuhn marked this pull request as ready for review May 31, 2023 20:55
suricactus
suricactus approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some tests last month, worked well. Let it be!

@m-kuhn m-kuhn merged commit e748eca into master Jun 7, 2023
@m-kuhn m-kuhn deleted the m-kuhn-patch-1 branch June 7, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suricactus suricactus suricactus approved these changes

Assignees

@suricactus suricactus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-kuhn @suricactus