Do not exclude vector layers when estimating the extent of the project #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removed if condition somehow slipped in, I don't see why it was
added in the first place. I guess it was part poor attempt to rewrite
the original code from commit `1df4f4090d847e50422881aca1af2595eb2ddb09`:
```
# Only vector layers
mapsettings.setLayers(
[layers[key] for key in layers if type(layers[key]) == QgsVectorLayer]
)
extent = mapsettings.fullExtent()
```
However, it is not clear why the if condition has been inverted, neither
why the if condition was needed in the first place. If one says it's to
prevent the infinite extent of the XYZ layers, the current code already
checks for that a few lines below:
```
if layer_extent.isNull() or not layer_extent.isFinite():
continue
```
In any case, this line is removed for good now.
|
Task linked: QF-3988 Failed to obtain project extent |
nirvn
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed if condition somehow slipped in, I don't see why it was added in the first place. I guess it was part poor attempt to rewrite the original code from commit
1df4f4090d847e50422881aca1af2595eb2ddb09:However, it is not clear why the if condition has been inverted, neither why the if condition was needed in the first place. If one says it's to prevent the infinite extent of the XYZ layers, the current code already checks for that a few lines below:
In any case, this line is removed for good now.