Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QF-4070 fix Delta Apply stuck in "Started" #941

Merged
merged 2 commits into from
May 27, 2024

Conversation

dddpt
Copy link
Contributor

@dddpt dddpt commented May 7, 2024

Fixed delta apply stuck in started, there were two cases in cron.py and wrapper.py. See clickup for detailed discussion of the error investigation.

In addition, I ensured error logs were more thoroughly downstreamed from jobs to deltas in DeltaApplyJobRun.after_docker_exception().

Do review thoroughly how I handled models update (especially in cron.py) as I am not super-familiar with Django models ;-)

@dddpt dddpt requested a review from suricactus May 7, 2024 15:24
@duke-nyuki
Copy link
Collaborator

Task linked: QF-4070 Delta Apply stuck in "Started"

@suricactus suricactus requested a review from boardend May 22, 2024 14:24
@suricactus
Copy link
Collaborator

@dddpt I allowed myself to hijack this PR and apply a few fixes here, as we should not bother you too much these weeks.

@boardend I know this review request came out of nowhere, but I thought it is a nice opportunity to get familiar with the delta models. :)

Copy link
Contributor

@boardend boardend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suricactus suricactus merged commit 847d82d into master May 27, 2024
6 of 8 checks passed
@suricactus suricactus deleted the QF-4070-fix-delta-apply-stuck-started branch May 27, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants