QF-4070 fix Delta Apply stuck in "Started" #941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed delta apply stuck in started, there were two cases in
cron.py
andwrapper.py
. See clickup for detailed discussion of the error investigation.In addition, I ensured error logs were more thoroughly downstreamed from jobs to deltas in
DeltaApplyJobRun.after_docker_exception()
.Do review thoroughly how I handled models update (especially in
cron.py
) as I am not super-familiar with Django models ;-)