You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updates to more than one nested property in the forms schema result in the entire nested object being overridden.
For example, if implementing webhook retries, updating the new form.webhooks.retries parameter would cause form.webhooks.webhookUrl to be overridden because the use of assignIn in the updateForm function only merges objects shallowly, such that the entire form.webhooks is replaced.
A previous attempt to fix this with recursive merge behavior had to be reverted in #1115, because logic fields actually rely on shallow merge behavior to replace the entire logic fields array.
This bug has not affected production yet because we currently do not have more than one nested property in the form schema.
The text was updated successfully, but these errors were encountered:
liangyuanruo
changed the title
PUT /{formId}/adminform does not update more than one nested property
Deprecate PUT /{formId}/adminform API endpoint
Mar 30, 2021
Updates to more than one nested property in the forms schema result in the entire nested object being overridden.
For example, if implementing webhook retries, updating the new
form.webhooks.retries
parameter would causeform.webhooks.webhookUrl
to be overridden because the use ofassignIn
in theupdateForm
function only merges objects shallowly, such that the entireform.webhooks
is replaced.A previous attempt to fix this with recursive merge behavior had to be reverted in #1115, because logic fields actually rely on shallow merge behavior to replace the entire logic fields array.
This bug has not affected production yet because we currently do not have more than one nested property in the form schema.
The text was updated successfully, but these errors were encountered: