Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-post] Deprecate PUT /{formId}/adminform API endpoint #1210

Closed
liangyuanruo opened this issue Feb 22, 2021 · 1 comment
Closed

[API-post] Deprecate PUT /{formId}/adminform API endpoint #1210

liangyuanruo opened this issue Feb 22, 2021 · 1 comment
Labels
bug Something isn't working P2 planned for next 1-2 months
Milestone

Comments

@liangyuanruo
Copy link
Contributor

liangyuanruo commented Feb 22, 2021

Updates to more than one nested property in the forms schema result in the entire nested object being overridden.

For example, if implementing webhook retries, updating the new form.webhooks.retries parameter would cause form.webhooks.webhookUrl to be overridden because the use of assignIn in the updateForm function only merges objects shallowly, such that the entire form.webhooks is replaced.

A previous attempt to fix this with recursive merge behavior had to be reverted in #1115, because logic fields actually rely on shallow merge behavior to replace the entire logic fields array.

This bug has not affected production yet because we currently do not have more than one nested property in the form schema.

@liangyuanruo liangyuanruo added bug Something isn't working P2 planned for next 1-2 months labels Feb 22, 2021
@r00dgirl
Copy link
Contributor

r00dgirl commented Mar 9, 2021

depends on #815 api refactoring

@r00dgirl r00dgirl added P3 and removed P2 planned for next 1-2 months labels Mar 10, 2021
@liangyuanruo liangyuanruo changed the title PUT /{formId}/adminform does not update more than one nested property Deprecate PUT /{formId}/adminform API endpoint Mar 30, 2021
@liangyuanruo liangyuanruo added P2 planned for next 1-2 months and removed P3 labels Mar 30, 2021
@liangyuanruo liangyuanruo added this to the API refactor milestone Mar 30, 2021
@karrui karrui changed the title Deprecate PUT /{formId}/adminform API endpoint [API-post] Deprecate PUT /{formId}/adminform API endpoint Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 planned for next 1-2 months
Projects
Status: Done
Development

No branches or pull requests

3 participants