Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate gtag.client.service.js to TypeScript #1834

Closed
liangyuanruo opened this issue May 10, 2021 · 1 comment
Closed

Migrate gtag.client.service.js to TypeScript #1834

liangyuanruo opened this issue May 10, 2021 · 1 comment
Labels
discuss to be discussed

Comments

@liangyuanruo
Copy link
Contributor

liangyuanruo commented May 10, 2021

This service contains the google analytics functions to report metrics correctly.

@liangyuanruo liangyuanruo added the discuss to be discussed label May 10, 2021
@mantariksh
Copy link
Contributor

Difficult to extricate from AngularJS due to reliance on $rootScope, so not much value in converting to TS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss to be discussed
Projects
None yet
Development

No branches or pull requests

2 participants