feat(config): allow R2 bucket URLs #7097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoneRifle
force-pushed
the
feat/config/r2
branch
from
d4dd84b
to
3751032
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
LoneRifle
force-pushed
the
feat/config/r2
branch
3 times, most recently
from
c26571a
to
ef35d7a
Compare
LoneRifle
force-pushed
the
feat/config/r2
branch
from
ef35d7a
to
3f26cad
Compare
KenLSM
reviewed
Feb 20, 2024
KenLSM
approved these changes
Feb 20, 2024
- Allow config to accept URLs to R2 buckets, in addition to S3 buckets - Force path-style S3 URLs for R2 buckets, not just for dev mode
LoneRifle
force-pushed
the
feat/config/r2
branch
from
3f26cad
to
97f5582
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
FormSG assumes in production environments that S3 buckets are hosted by AWS and use URLs that take after a certain pattern. This is not necessarily the case for eg, Cloudflare R2, which use a different pattern
Solution