Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update eslint packages to stable latest versions #7277

Merged
merged 7 commits into from
May 15, 2024
Merged

feat: update eslint packages to stable latest versions #7277

merged 7 commits into from
May 15, 2024
+5,796 −3,646

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Apr 23, 2024 •
edited
Loading

ESLint very outdated. Time to fix it. Part of my package upgrading spree. Plan of action:

  1. ESLint
  2. Prettier (big changes)
  3. CRA -> Vite
  4. Storybook v8
  5. React 17 -> 18 + Chakra UI v1 -> 2 (no choice have to do together) (mega changes)
  6. Update typescript versions to v5 across app
  7. Use OGPDS with FormSG theme and pray there are no regressions
  8. Update react query and rhf to their latest incarnations
  9. fin

@karrui Graphite App
Copy link
Contributor Author

karrui commented Apr 23, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @karrui and the rest of your teammates on Graphite Graphite

@karrui karrui mentioned this pull request Apr 23, 2024
Merged
@karrui karrui requested review from justynoh and KenLSM April 23, 2024 06:57
@karrui karrui marked this pull request as ready for review April 23, 2024 06:58
@karrui
Copy link
Contributor Author

karrui commented Apr 23, 2024

oops missed one package

@karrui karrui mentioned this pull request Apr 23, 2024
Merged
@karrui karrui force-pushed the upgrade-eslint-and-prettier branch from 86ceffb to 8c1559d Compare April 23, 2024 07:51
@karrui
Copy link
Contributor Author

karrui commented Apr 23, 2024

All the ignored lint errors.... out of scope of this PR though... might fix those in a previous PR then T_T

@karrui karrui force-pushed the upgrade-eslint-and-prettier branch from 577700b to 4db5926 Compare April 24, 2024 07:56
This was referenced Apr 24, 2024
Open
Open
justynoh
justynoh approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@justynoh justynoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karrui karrui force-pushed the upgrade-eslint-and-prettier branch from 4db5926 to 4ffd43f Compare May 2, 2024 04:34
This was referenced May 2, 2024
Open
Draft
@KenLSM KenLSM merged commit e5a020f into develop May 15, 2024
27 of 28 checks passed
@KenLSM KenLSM deleted the upgrade-eslint-and-prettier branch May 15, 2024 12:34
@KenLSM KenLSM mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justynoh justynoh justynoh approved these changes

@KenLSM KenLSM Awaiting requested review from KenLSM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karrui @justynoh @KenLSM