-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate from CRA4 to Vite, Storybook to v8, jest to Vitest #7285
Open
karrui
wants to merge
26
commits into
develop
Choose a base branch
from
04-23-feat_add_initial_vite_config_and_new_eslint_rules
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: migrate from CRA4 to Vite, Storybook to v8, jest to Vitest #7285
karrui
wants to merge
26
commits into
develop
from
04-23-feat_add_initial_vite_config_and_new_eslint_rules
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 24, 2024
karrui
changed the title
feat: add initial vite config and new eslint rules
wip: migrate from CRA4 to Vite
Apr 24, 2024
@KenLSM see chromatic useful. will ensure the migration has 0 frontend changes!!! |
karrui
changed the title
wip: migrate from CRA4 to Vite
wip: migrate from CRA4 to Vite, Storybook to v8, jest to Vitest
Apr 26, 2024
karrui
changed the title
wip: migrate from CRA4 to Vite, Storybook to v8, jest to Vitest
feat: migrate from CRA4 to Vite, Storybook to v8, jest to Vitest
Apr 26, 2024
@justynoh this PR officially has no regressions hehehehe |
@justynoh added datadog chunking back to the pipeline. Can push to staging to try? |
karrui
force-pushed
the
04-23-fix_remove_erroneous_react_type_pkg_install_on_root
branch
from
May 2, 2024 04:34
0a96443
to
9f75cd7
Compare
karrui
force-pushed
the
04-23-feat_add_initial_vite_config_and_new_eslint_rules
branch
from
May 2, 2024 04:34
2c7a9e4
to
9177241
Compare
karrui
commented
May 2, 2024
karrui
commented
May 2, 2024
karrui
commented
May 2, 2024
Base automatically changed from
04-23-fix_remove_erroneous_react_type_pkg_install_on_root
to
04-23-feat_upgrade_prettier_to_v3
May 15, 2024 12:34
KenLSM
approved these changes
Jun 11, 2024
v2 requires more changes, not worth it for now
actually good to snapshot full page instead of just fixed pages
hypothesis is that multiple toasts are rendering???
does not seem to be needed now that we use vite
KenLSM
force-pushed
the
04-23-feat_add_initial_vite_config_and_new_eslint_rules
branch
from
June 11, 2024 14:45
2856457
to
f2a558a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the frontend toolchain from CRA4 to Vite.
Generally everything seems to be working fine, including decryption workers.
Requires a bunch of changes that has to be performed all at the same time:
TODO: