Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v4.50.0 #862

Merged
merged 13 commits into from
Dec 14, 2020
Merged

build: release v4.50.0 #862

merged 13 commits into from
Dec 14, 2020

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Dec 14, 2020

Release v4.50.0

Halfway to the 4.100.0 mark!

Improvements

  • chore: improve logging when answer is undefined #856
  • fix: Put email domain restriction behind verified-fields feature toggle #852
  • refactor: migrate saveMetadataToDb to TypeScript #778
  • refactor: migrate sendAdminEmail to TypeScript #781
  • refactor: migrate isFormPublic middleware to TypeScript #791

Dependency upgrades

  • fix: run npm audit fix #858
  • fix(deps): bump angular-animate from 1.8.0 to 1.8.2 #860
  • chore(deps-dev): bump @types/express from 4.17.8 to 4.17.9 #840
  • chore(deps-dev): bump @types/express-serve-static-core #841
  • chore(deps-dev): bump @types/mongodb from 3.5.34 to 3.6.3 #839
  • chore(deps-dev): bump babel-loader from 8.2.1 to 8.2.2 #859

mantariksh and others added 13 commits December 10, 2020 19:52
@mantariksh
Merge pull request #850 from opengovsg/release-4.49.1
0f4816f 
build: merge Release 4.49.1 into develop
@mantariksh
refactor: migrate saveMetadataToDb to TypeScript (#778)
ee26e78
@mantariksh
chore: improve logging when answer is undefined (#856)
ad6d205
@mantariksh
refactor: migrate sendAdminEmail to TypeScript (#781)
794a6e2
@dependabot
chore(deps-dev): bump @types/express from 4.17.8 to 4.17.9 (#840)
a277fcb 
Bumps [@types/express](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express) from 4.17.8 to 4.17.9.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @types/mongodb from 3.5.34 to 3.6.3 (#839)
ca57bc0 
Bumps [@types/mongodb](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mongodb) from 3.5.34 to 3.6.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mongodb)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@liangyuanruo
refactor/is-form-public: migrate isFormPublic middleware to TypeScript (
a8ec327 
#791)
@dependabot
chore(deps-dev): bump @types/express-serve-static-core (#841)
b6ae391 
Bumps [@types/express-serve-static-core](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express-serve-static-core) from 4.17.14 to 4.17.15.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express-serve-static-core)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@liangyuanruo
fix: run npm audit fix (#858)
bedeec8 
Co-authored-by: Yuanruo Liang <yuanruo@open.gov.sg>
@dependabot
fix(deps): bump angular-animate from 1.8.0 to 1.8.2 (#860)
edefc9a 
Bumps [angular-animate](https://github.com/angular/angular.js) from 1.8.0 to 1.8.2.
- [Release notes](https://github.com/angular/angular.js/releases)
- [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md)
- [Commits](angular/angular.js@v1.8.0...v1.8.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump babel-loader from 8.2.1 to 8.2.2 (#859)
57d2d39 
Bumps [babel-loader](https://github.com/babel/babel-loader) from 8.2.1 to 8.2.2.
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](babel/babel-loader@v8.2.1...v8.2.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jia1
fix: Put email domain restriction behind verified-fields feature togg…
8ce5819 
…le (#852)
@karrui
chore: bump version to v4.50.0
2158726
@karrui karrui changed the base branch from develop to release December 14, 2020 02:18
@karrui
Copy link
Contributor Author

karrui commented Dec 14, 2020 •
edited by mantariksh
Loading

@mantariksh

Tests

Email domain restriction fixes

  • On staging, email domain restriction toggle in email fields should show up and be able to be toggled on/off
  • On staging-alt (without the verified fields feature enabled), email domain restriction toggle in email fields should not show up.

@mantariksh
Copy link
Contributor

mantariksh commented Dec 14, 2020 •
edited by tshuli
Loading

Tests

Email submissions

@tshuli

  • Submit an email form with an attachment. Check that the submission is saved to the database with a response hash.
  • Submit the form with a different attachment and check that the hash is different.

@karrui
Copy link
Contributor Author

karrui commented Dec 14, 2020 •
edited by mantariksh
Loading

@mantariksh

Tests

Typescript refactors

  • Viewing an archived form as public form filler should return 410
  • Viewing a private form as public form filler should return 404 with form's inactive message
  • Viewing a public form as public form filler should resolve successfully

@karrui
Copy link
Contributor Author

karrui commented Dec 14, 2020 •
edited by tshuli
Loading

@karrui

Tests

IE11 intranet tests for this week

  • Submit an email form with an attachment. Check that the submission is saved to the database with a response hash.
  • Submit the form with a different attachment and check that the hash is different.

IE11 intranet general run-through

  • Create email mode form with all fields. Activate and submit form. Check that you can receive responses in your GSIB inbox.
  • Collaborators can be added in email mode.
  • Create storage mode form with all fields. Activate and submit form.
  • Response CSV can be downloaded for storage mode.
  • Responses can be viewed in Data tab in storage mode.
  • Attachments can be downloaded from Data tab in storage mode.
  • Submission IDs can be filtered in storage mode.
  • Collaborators can be added and their collaborating rights edited in storage mode.

@karrui karrui merged commit affe931 into release Dec 14, 2020
@liangyuanruo liangyuanruo deleted the release-v4.50.0 branch January 14, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karrui @mantariksh @liangyuanruo @jia1