Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs on Announcement Modal #733

Closed
lisa-kwok opened this issue Oct 14, 2020 · 2 comments
Closed

Bugs on Announcement Modal #733

lisa-kwok opened this issue Oct 14, 2020 · 2 comments
Assignees
@LoneRifle
Labels
bug Something isn't working

Comments

@lisa-kwok
Copy link

Describe the bug

  1. Missing padding in the text body
  2. Odd scaling of image in large screens

Screenshot_20201014-165359
Screenshot 2020-10-14 at 5 21 30 PM
Screenshot 2020-10-14 at 5 21 21 PM
@lisa-kwok lisa-kwok added the bug Something isn't working label Oct 14, 2020
@lisa-kwok lisa-kwok changed the title Announcement Modal Bugs on Announcement Modal Oct 14, 2020
@LoneRifle LoneRifle mentioned this issue Oct 15, 2020
Merged
@LoneRifle
Copy link
Contributor

The image scaling issues is due to the large block of text competing for screen real estate with the image, with the text taking precedence. I would argue that we should leave the scaling as-is to allow as much text to be displayed within the modal as possible

@LoneRifle LoneRifle mentioned this issue Oct 28, 2020
Closed
@lisa-kwok
Copy link
Author

fixed and merged

@liangyuanruo liangyuanruo mentioned this issue Feb 29, 2024
Closed
This was referenced Mar 18, 2024
Closed
Closed
This was referenced Mar 26, 2024
Closed
Closed
@liangyuanruo liangyuanruo mentioned this issue Apr 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LoneRifle LoneRifle

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(announcement): limit image size opengovsg/GoGovSG
2 participants
@LoneRifle @lisa-kwok