Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client: should revert on TransactionFailed #95

Closed
drortirosh opened this issue Apr 14, 2019 · 0 comments
Closed

Client: should revert on TransactionFailed #95

drortirosh opened this issue Apr 14, 2019 · 0 comments
Labels
client JS client library

Comments

@drortirosh
Copy link
Member

Client's RelayProvider already recognized failed transaction (event TransactionRelayed with status=0) and treat it as failure.
With #94, the relay() transaction doesn't gets reverted in case of contract problem, but it means that the client can behave strangely, as it "thinks" the transaction succeded.
Instead, the RelayProvider should check for TransactionFailed too, and report it as failure.
@drortirosh drortirosh added the client JS client library label Apr 14, 2019
@shahafn shahafn closed this as completed Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client JS client library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shahafn @drortirosh