Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shelly] Info on "not reachable / timeout" should be warning, not info #10039

Closed
openPhiL opened this issue Feb 3, 2021 · 2 comments · Fixed by #10815
Closed

[shelly] Info on "not reachable / timeout" should be warning, not info #10039

openPhiL opened this issue Feb 3, 2021 · 2 comments · Fixed by #10815
Assignees
@markus7017
Labels
bug An unexpected problem or unintended behavior of an add-on PR pending There is a pull request for resolving the issue

Comments

@openPhiL
Copy link

openPhiL commented Feb 3, 2021

Hi!
I found this in my logs:

2021-02-03 16:31:14.111 [INFO ] [y.internal.handler.ShellyBaseHandler] - shellyswitch25-690977: FEHLER: Der Befehl 60 f?r Kanal shelly:shelly25-roller:690977:roller#control kann nicht verarbeitet werden - Device unreachable or API Timeout ()

I can explain why - It broke, I removed it.

I do expect this as a "Problem".. an "Error". Translation of the text starts also with "Fehler". But it is logged as an "Info".
I assume this is not on purpose, so I create this Issue.

Expected Behavior

Log should state:

2021-02-03 16:31:14.111 [ERROR ] [y.internal.handler.ShellyBaseHandler] - shellyswitch25-690977: FEHLER: Der Befehl 60 f?r Kanal shelly:shelly25-roller:690977:roller#control kann nicht verarbeitet werden - Device unreachable or API Timeout ()

Current Behavior

Log currently states:
2021-02-03 16:31:14.111 [INFO] [y.internal.handler.ShellyBaseHandler] - shellyswitch25-690977: FEHLER: Der Befehl 60 f?r Kanal shelly:shelly25-roller:690977:roller#control kann nicht verarbeitet werden - Device unreachable or API Timeout ()

Possible Solution

developer-magic

Steps to Reproduce (for Bugs)

take hammer, smash shelly, check logs.

Context

Your Environment

I use Openhab3 stable with shelly 3.0.0, installed with regular gui clicking.

Best regards
PhiL
@openPhiL openPhiL added the bug An unexpected problem or unintended behavior of an add-on label Feb 3, 2021
@wborn wborn changed the title [shelly] - Info on "not reachable / timeout" should be warning, not info [shelly] Info on "not reachable / timeout" should be warning, not info May 12, 2021
@markus7017 markus7017 self-assigned this Jun 6, 2021
@markus7017
Copy link
Contributor

changed, lets see if this passes the review

@markus7017 markus7017 added the PR pending There is a pull request for resolving the issue label Jun 6, 2021
markus7017 added a commit to markus7017/openhab-addons that referenced this issue Jun 6, 2021
@markus7017
- Feature openhab#10090 New device#supplyVoltage channel for Shelly 2…
e4a54bb 
….5, 1PM

and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017 markus7017 mentioned this issue Jun 6, 2021
Merged
@markus7017 markus7017 linked a pull request Jun 6, 2021 that will close this issue
[shelly] 1PM/1L/2.5: New device#supplyVoltage; Motion: Missing channel for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp #10815
Merged
@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/shelly-binding/56862/2190

markus7017 added a commit to markus7017/openhab-addons that referenced this issue Jun 6, 2021
@markus7017
- Feature openhab#10090 New device#supplyVoltage channel for Shelly 2…
7daef6e 
….5, 1PM

and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>
markus7017 added a commit to markus7017/openhab-addons that referenced this issue Jun 14, 2021
@markus7017
- Feature openhab#10090 New device#supplyVoltage channel for Shelly 2…
d1bde62 
….5, 1PM

and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>
fwolter pushed a commit that referenced this issue Jun 15, 2021
@markus7017
[shelly] 1PM/1L/2.5: New device#supplyVoltage; Motion: Missing channe…
d0f4b84 
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (#10815)

* fixes #10738, #10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature #10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  #10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     #10799 Missing Channel Definition for Vibration Events
- Fix     #10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     #10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* #10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for #10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this issue Jul 13, 2021
@markus7017 @computergeek1507
[shelly] 1PM/1L/2.5: New device#supplyVoltage; Motion: Missing channe…
bf8b0fe 
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this issue Jul 26, 2021
@markus7017 @lucacalcaterra
[shelly] 1PM/1L/2.5: New device#supplyVoltage; Motion: Missing channe…
6b39ab2 
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this issue Jul 26, 2021
@markus7017 @lucacalcaterra
[shelly] 1PM/1L/2.5: New device#supplyVoltage; Motion: Missing channe…
4ed75c9 
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this issue Aug 3, 2021
@markus7017 @lucacalcaterra
[shelly] 1PM/1L/2.5: New device#supplyVoltage; Motion: Missing channe…
c6873e5 
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this issue Oct 26, 2021
@markus7017 @frederictobiasc
[shelly] 1PM/1L/2.5: New device#supplyVoltage; Motion: Missing channe…
ad6cbe5 
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this issue Nov 7, 2021
@markus7017 @thinkingstone
[shelly] 1PM/1L/2.5: New device#supplyVoltage; Motion: Missing channe…
0cfda58 
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this issue May 5, 2022
@markus7017
[shelly] 1PM/1L/2.5: New device#supplyVoltage; Motion: Missing channe…
92542af 
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markus7017 markus7017

Labels
bug An unexpected problem or unintended behavior of an add-on PR pending There is a pull request for resolving the issue
Projects
None yet
Milestone
No milestone
3 participants
@openhab-bot @markus7017 @openPhiL