Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shelly] Shelly EM - add powerFactor channel support #10737

Closed
Mark-VG opened this issue May 22, 2021 · 3 comments · Fixed by #10815
Closed

[shelly] Shelly EM - add powerFactor channel support #10737

Mark-VG opened this issue May 22, 2021 · 3 comments · Fixed by #10815
Assignees
Labels
enhancement An enhancement or new feature for an existing add-on PR pending There is a pull request for resolving the issue

Comments

@Mark-VG
Copy link

Mark-VG commented May 22, 2021

  • Version used: openHAB 3.1.0.M4
  • Environment name and version: Java Runtime Azul Systems, Inc. 11.0.9.1 (Zulu11.43+55-CA)
  • Operating System and version: Windows 10/10.0 (amd64

The Shelly EM3 supports the powerFactor channel as per the docs.

It appears however that the ShellyEM does not support the powerFactor channel, even though this appears to be available on the device:
Shelly EM PF

Firmware on Device: 20210429-102232/v1.10.4-g3f94cd7

The PF is used to calculate an accurate VA value from the reported Watts value so is important.

Would it be possible to implement this as a feature?

@Mark-VG Mark-VG added the enhancement An enhancement or new feature for an existing add-on label May 22, 2021
@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/shelly-binding/56862/2162

@markus7017 markus7017 self-assigned this Jun 5, 2021
@markus7017
Copy link
Contributor

There should already be the channel meter#powerFactor
if should be created when the emeter json has the value pf
if not please provide the output from http://<device ip>/status

@markus7017 markus7017 added the PR pending There is a pull request for resolving the issue label Jun 7, 2021
@markus7017
Copy link
Contributor

implemented

markus7017 added a commit to markus7017/openhab-addons that referenced this issue Jun 7, 2021
Signed-off-by: Markus Michels <markus7017@gmail.com>
markus7017 added a commit to markus7017/openhab-addons that referenced this issue Jun 7, 2021
Signed-off-by: Markus Michels <markus7017@gmail.com>
markus7017 added a commit to markus7017/openhab-addons that referenced this issue Jun 14, 2021
Signed-off-by: Markus Michels <markus7017@gmail.com>
fwolter pushed a commit that referenced this issue Jun 15, 2021
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (#10815)

* fixes #10738, #10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature #10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  #10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     #10799 Missing Channel Definition for Vibration Events
- Fix     #10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     #10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* #10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for #10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this issue Jul 13, 2021
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this issue Jul 26, 2021
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this issue Jul 26, 2021
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this issue Aug 3, 2021
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this issue Oct 26, 2021
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this issue Nov 7, 2021
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this issue May 5, 2022
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on PR pending There is a pull request for resolving the issue
Projects
None yet
3 participants