Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shelly] 1PM/1L/2.5: New device#supplyVoltage; Motion: Missing channel for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp #10815

Merged
merged 7 commits into from Jun 15, 2021

Conversation

markus7017
Copy link
Contributor

@markus7017 markus7017 commented Jun 6, 2021

This PR includes some minor fixes and improvements:

Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of this PR will appear in the changelog. Can you express what you actually changed?

@markus7017 markus7017 changed the title [shelly] Small improvements and bug fixes [shelly] 1PM/1L/2.5: New device#supplyVoltage; Motion: Missing channel for vibration; UNI: Unit for ADC voltage; Bulb: fix range for color temp Jun 7, 2021
@markus7017 markus7017 added bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jun 7, 2021
@markus7017 markus7017 linked an issue Jun 7, 2021 that may be closed by this pull request
@markus7017 markus7017 changed the title [shelly] 1PM/1L/2.5: New device#supplyVoltage; Motion: Missing channel for vibration; UNI: Unit for ADC voltage; Bulb: fix range for color temp [shelly] 1PM/1L/2.5: New device#supplyVoltage; Motion: Missing channel for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp Jun 7, 2021
@markus7017
Copy link
Contributor Author

@fwolter added on more fix and answered your question

@markus7017
Copy link
Contributor Author

@openhab/add-ons-maintainers Please make sure to include this PR in the final 3.1 release - no need to have those bugs there

Signed-off-by: Markus Michels <markus7017@gmail.com>
….5, 1PM

and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017 markus7017 linked an issue Jun 14, 2021 that may be closed by this pull request
@markus7017
Copy link
Contributor Author

@fwolter I added fix #10864

Signed-off-by: Markus Michels <markus7017@gmail.com>
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter merged commit d0f4b84 into openhab:main Jun 15, 2021
@markus7017 markus7017 deleted the shelly_snapshot31 branch June 18, 2021 14:28
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Aug 3, 2021
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815)

* fixes openhab#10738, openhab#10799

Signed-off-by: Markus Michels <markus7017@gmail.com>

* - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM
and 1L
- Change  openhab#10039 Info on "not reachable / timeout" should be warning,
not info
- Fix     openhab#10799 Missing Channel Definition for Vibration Events
- Fix     openhab#10738 Shelly UNI - ADC Voltage units of measure missing
- Fix     openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong
min/max
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10737 Shelly EM - add powerFactor channel support

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* channel powerFactor (EM+EM3) is now of type Number:Dimensionless

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Fix for openhab#10864: Do not trigger same alarm within 5 minutes

Signed-off-by: Markus Michels <markus7017@gmail.com>

* better logic for alarm filter

Signed-off-by: Markus Michels <markus7017@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment