New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shelly] 1PM/1L/2.5: New device#supplyVoltage; Motion: Missing channel for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp #10815
Conversation
e4a54bb
to
7daef6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title of this PR will appear in the changelog. Can you express what you actually changed?
...ing.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyRelayHandler.java
Show resolved
Hide resolved
@fwolter added on more fix and answered your question |
@openhab/add-ons-maintainers Please make sure to include this PR in the final 3.1 release - no need to have those bugs there |
Signed-off-by: Markus Michels <markus7017@gmail.com>
….5, 1PM and 1L - Change openhab#10039 Info on "not reachable / timeout" should be warning, not info - Fix openhab#10799 Missing Channel Definition for Vibration Events - Fix openhab#10738 Shelly UNI - ADC Voltage units of measure missing - Fix openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong min/max - README updated Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
6d97d3e
to
dc3d0e9
Compare
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815) * fixes openhab#10738, openhab#10799 Signed-off-by: Markus Michels <markus7017@gmail.com> * - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM and 1L - Change openhab#10039 Info on "not reachable / timeout" should be warning, not info - Fix openhab#10799 Missing Channel Definition for Vibration Events - Fix openhab#10738 Shelly UNI - ADC Voltage units of measure missing - Fix openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong min/max - README updated Signed-off-by: Markus Michels <markus7017@gmail.com> * openhab#10737 Shelly EM - add powerFactor channel support Signed-off-by: Markus Michels <markus7017@gmail.com> * README updated Signed-off-by: Markus Michels <markus7017@gmail.com> * channel powerFactor (EM+EM3) is now of type Number:Dimensionless Signed-off-by: Markus Michels <markus7017@gmail.com> * Fix for openhab#10864: Do not trigger same alarm within 5 minutes Signed-off-by: Markus Michels <markus7017@gmail.com> * better logic for alarm filter Signed-off-by: Markus Michels <markus7017@gmail.com>
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815) * fixes openhab#10738, openhab#10799 Signed-off-by: Markus Michels <markus7017@gmail.com> * - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM and 1L - Change openhab#10039 Info on "not reachable / timeout" should be warning, not info - Fix openhab#10799 Missing Channel Definition for Vibration Events - Fix openhab#10738 Shelly UNI - ADC Voltage units of measure missing - Fix openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong min/max - README updated Signed-off-by: Markus Michels <markus7017@gmail.com> * openhab#10737 Shelly EM - add powerFactor channel support Signed-off-by: Markus Michels <markus7017@gmail.com> * README updated Signed-off-by: Markus Michels <markus7017@gmail.com> * channel powerFactor (EM+EM3) is now of type Number:Dimensionless Signed-off-by: Markus Michels <markus7017@gmail.com> * Fix for openhab#10864: Do not trigger same alarm within 5 minutes Signed-off-by: Markus Michels <markus7017@gmail.com> * better logic for alarm filter Signed-off-by: Markus Michels <markus7017@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815) * fixes openhab#10738, openhab#10799 Signed-off-by: Markus Michels <markus7017@gmail.com> * - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM and 1L - Change openhab#10039 Info on "not reachable / timeout" should be warning, not info - Fix openhab#10799 Missing Channel Definition for Vibration Events - Fix openhab#10738 Shelly UNI - ADC Voltage units of measure missing - Fix openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong min/max - README updated Signed-off-by: Markus Michels <markus7017@gmail.com> * openhab#10737 Shelly EM - add powerFactor channel support Signed-off-by: Markus Michels <markus7017@gmail.com> * README updated Signed-off-by: Markus Michels <markus7017@gmail.com> * channel powerFactor (EM+EM3) is now of type Number:Dimensionless Signed-off-by: Markus Michels <markus7017@gmail.com> * Fix for openhab#10864: Do not trigger same alarm within 5 minutes Signed-off-by: Markus Michels <markus7017@gmail.com> * better logic for alarm filter Signed-off-by: Markus Michels <markus7017@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815) * fixes openhab#10738, openhab#10799 Signed-off-by: Markus Michels <markus7017@gmail.com> * - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM and 1L - Change openhab#10039 Info on "not reachable / timeout" should be warning, not info - Fix openhab#10799 Missing Channel Definition for Vibration Events - Fix openhab#10738 Shelly UNI - ADC Voltage units of measure missing - Fix openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong min/max - README updated Signed-off-by: Markus Michels <markus7017@gmail.com> * openhab#10737 Shelly EM - add powerFactor channel support Signed-off-by: Markus Michels <markus7017@gmail.com> * README updated Signed-off-by: Markus Michels <markus7017@gmail.com> * channel powerFactor (EM+EM3) is now of type Number:Dimensionless Signed-off-by: Markus Michels <markus7017@gmail.com> * Fix for openhab#10864: Do not trigger same alarm within 5 minutes Signed-off-by: Markus Michels <markus7017@gmail.com> * better logic for alarm filter Signed-off-by: Markus Michels <markus7017@gmail.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815) * fixes openhab#10738, openhab#10799 Signed-off-by: Markus Michels <markus7017@gmail.com> * - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM and 1L - Change openhab#10039 Info on "not reachable / timeout" should be warning, not info - Fix openhab#10799 Missing Channel Definition for Vibration Events - Fix openhab#10738 Shelly UNI - ADC Voltage units of measure missing - Fix openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong min/max - README updated Signed-off-by: Markus Michels <markus7017@gmail.com> * openhab#10737 Shelly EM - add powerFactor channel support Signed-off-by: Markus Michels <markus7017@gmail.com> * README updated Signed-off-by: Markus Michels <markus7017@gmail.com> * channel powerFactor (EM+EM3) is now of type Number:Dimensionless Signed-off-by: Markus Michels <markus7017@gmail.com> * Fix for openhab#10864: Do not trigger same alarm within 5 minutes Signed-off-by: Markus Michels <markus7017@gmail.com> * better logic for alarm filter Signed-off-by: Markus Michels <markus7017@gmail.com>
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815) * fixes openhab#10738, openhab#10799 Signed-off-by: Markus Michels <markus7017@gmail.com> * - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM and 1L - Change openhab#10039 Info on "not reachable / timeout" should be warning, not info - Fix openhab#10799 Missing Channel Definition for Vibration Events - Fix openhab#10738 Shelly UNI - ADC Voltage units of measure missing - Fix openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong min/max - README updated Signed-off-by: Markus Michels <markus7017@gmail.com> * openhab#10737 Shelly EM - add powerFactor channel support Signed-off-by: Markus Michels <markus7017@gmail.com> * README updated Signed-off-by: Markus Michels <markus7017@gmail.com> * channel powerFactor (EM+EM3) is now of type Number:Dimensionless Signed-off-by: Markus Michels <markus7017@gmail.com> * Fix for openhab#10864: Do not trigger same alarm within 5 minutes Signed-off-by: Markus Michels <markus7017@gmail.com> * better logic for alarm filter Signed-off-by: Markus Michels <markus7017@gmail.com>
…l for vibration; UNI: Unit for ADC voltage; PF for EM; Bulb: fix range for color temp (openhab#10815) * fixes openhab#10738, openhab#10799 Signed-off-by: Markus Michels <markus7017@gmail.com> * - Feature openhab#10090 New device#supplyVoltage channel for Shelly 2.5, 1PM and 1L - Change openhab#10039 Info on "not reachable / timeout" should be warning, not info - Fix openhab#10799 Missing Channel Definition for Vibration Events - Fix openhab#10738 Shelly UNI - ADC Voltage units of measure missing - Fix openhab#10111 Creating Equipment from Shelly Bulb Duo causes wrong min/max - README updated Signed-off-by: Markus Michels <markus7017@gmail.com> * openhab#10737 Shelly EM - add powerFactor channel support Signed-off-by: Markus Michels <markus7017@gmail.com> * README updated Signed-off-by: Markus Michels <markus7017@gmail.com> * channel powerFactor (EM+EM3) is now of type Number:Dimensionless Signed-off-by: Markus Michels <markus7017@gmail.com> * Fix for openhab#10864: Do not trigger same alarm within 5 minutes Signed-off-by: Markus Michels <markus7017@gmail.com> * better logic for alarm filter Signed-off-by: Markus Michels <markus7017@gmail.com>
This PR includes some minor fixes and improvements: