Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[homeconnect] Fix update of channels linked to program options #10990

Merged
merged 1 commit into from
Aug 4, 2021
Merged

[homeconnect] Fix update of channels linked to program options #10990

merged 1 commit into from
Aug 4, 2021

Conversation

lolodomo
Copy link
Contributor

Fix #10955

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Jul 13, 2021
@lolodomo lolodomo requested a review from bruestel as a code owner July 13, 2021 10:03
@lolodomo
Copy link
Contributor Author

I tested it seriously but not when a washing program is running. That is why I marked as "additional testing preferred". I will do that the next time I will run a program.

@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jul 15, 2021
@lolodomo
Copy link
Contributor Author

@bruestel : for your information, once merged, I will submit another PR replacing calls to getChannel by getLinkedChannel when it is appropriate.

@bruestel
Copy link
Contributor

I tested it seriously but not when a washing program is running. That is why I marked as "additional testing preferred". I will do that the next time I will run a program.

Where you able to test it?

@lolodomo
Copy link
Contributor Author

Where you able to test it?

No, I have not yet done the additional tests I would like to do.

@lolodomo lolodomo added work in progress A PR that is not yet ready to be merged and removed additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Jul 26, 2021
@lolodomo lolodomo force-pushed the reset_unsued_channels branch 2 times, most recently from a82420c to c9d604e Compare July 26, 2021 18:18
@lolodomo
Copy link
Contributor Author

Doing more tests, I discovered that the option "vario perfect" Is disappearing from the API response when the program is running, even if it was set and available for this program. I should think about what to do.

This is ok for all other channels I am able to test.

@lolodomo lolodomo force-pushed the reset_unsued_channels branch 2 times, most recently from 2339438 to 4af74ec Compare July 30, 2021 22:13
@lolodomo
[homeconnect] Fix update of channels linked to program options
7e84fe4 
Fix openhab#10955

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo removed the work in progress A PR that is not yet ready to be merged label Jul 30, 2021
@lolodomo
Copy link
Contributor Author

@bruestel : that is now ready for a review.

This was referenced Jul 31, 2021
Merged
Merged
@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Aug 1, 2021
@kaikreuzer kaikreuzer added this to the 3.2 milestone Aug 4, 2021
@kaikreuzer kaikreuzer merged commit ebb2662 into openhab:main Aug 4, 2021
@lolodomo lolodomo deleted the reset_unsued_channels branch August 4, 2021 14:19
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@lolodomo @frederictobiasc
[homeconnect] Fix update of channels linked to program options (openh…
b76527d 
…ab#10990)

Fix openhab#10955

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@lolodomo @thinkingstone
[homeconnect] Fix update of channels linked to program options (openh…
4c824e5 
…ab#10990)

Fix openhab#10955

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this pull request Nov 9, 2021
@lolodomo @dschoepel
[homeconnect] Fix update of channels linked to program options (openh…
62cf956 
…ab#10990)

Fix openhab#10955

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@lolodomo
[homeconnect] Fix update of channels linked to program options (openh…
0325622 
…ab#10990)

Fix openhab#10955

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruestel bruestel bruestel approved these changes

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

[homeconnect] Channels keeping old value when changing program
3 participants
@lolodomo @bruestel @kaikreuzer