Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homeconnect] 2 channels added for washer appliance #11071

Merged
merged 1 commit into from Aug 7, 2021

Conversation

lolodomo
Copy link
Contributor

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo added the awaiting other PR Depends on another PR label Jul 31, 2021
@lolodomo lolodomo requested a review from bruestel as a code owner July 31, 2021 15:56
@lolodomo
Copy link
Contributor Author

Code is based on PR #10990 so we have to wait for the merge of this other PR and then I will rebase this PR.
During this time, the code can already be reviewed.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/home-connect-addon-looking-for-beta-testers/49702/895

@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Aug 1, 2021
Copy link
Contributor

@bruestel bruestel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM lets wait for the other two PRs to be merged.

@kaikreuzer
Copy link
Member

@lolodomo This seems to require a rebase now.

@lolodomo
Copy link
Contributor Author

lolodomo commented Aug 4, 2021

@lolodomo This seems to require a rebase now.

I will wait for the merge of PR #11069 before rebasing.

@lolodomo lolodomo removed the awaiting other PR Depends on another PR label Aug 6, 2021
@lolodomo
Copy link
Contributor Author

lolodomo commented Aug 6, 2021

Rebase is now done. No more conflicts.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Aug 6, 2021
@kaikreuzer kaikreuzer merged commit bcd8908 into openhab:main Aug 7, 2021
@kaikreuzer kaikreuzer added this to the 3.2 milestone Aug 7, 2021
@lolodomo lolodomo deleted the homeconnect_2newchannels branch August 7, 2021 19:04
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this pull request Nov 9, 2021
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants