Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homeconnect] Use getLinkedChannel rather than getThingChannel ... #11069

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Jul 31, 2021

when the purpose is only to call the method updateState

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo added the awaiting other PR Depends on another PR label Jul 31, 2021
@lolodomo lolodomo requested a review from bruestel as a code owner July 31, 2021 09:35
@lolodomo
Copy link
Contributor Author

lolodomo commented Jul 31, 2021

Code is based on PR #10990 which introduced the method getLinkedChannel so we have to wait for the merge of this other PR and then I will rebase this PR.
During this time, the code can already be reviewed.

@lolodomo lolodomo changed the title [homeconnect] Use getLinkedChannel rather than getThingChannel when the purpose is only to call the method updateState [homeconnect] Use getLinkedChannel rather than getThingChannel ... Jul 31, 2021
@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Aug 1, 2021
Copy link
Contributor

@bruestel bruestel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to get rid of useless updates. Thanks.
As soon as the other PR is merged we can merge this one as well.

@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed awaiting other PR Depends on another PR rebuild Triggers Jenkins PR build labels Aug 4, 2021
when the purpose is only to call the method updateState

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo force-pushed the homeconnect_getLinkedChannel branch from 33beadc to 2662890 Compare August 4, 2021 16:40
@lolodomo
Copy link
Contributor Author

lolodomo commented Aug 4, 2021

PR is now rebased and ready for a review/merge.

@kaikreuzer kaikreuzer merged commit e3b8b93 into openhab:main Aug 4, 2021
@kaikreuzer kaikreuzer added this to the 3.2 milestone Aug 4, 2021
@lolodomo lolodomo deleted the homeconnect_getLinkedChannel branch August 4, 2021 20:52
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
…ab#11069)

when the purpose is only to call the method updateState

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
…ab#11069)

when the purpose is only to call the method updateState

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this pull request Nov 9, 2021
…ab#11069)

when the purpose is only to call the method updateState

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…ab#11069)

when the purpose is only to call the method updateState

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants