Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt] Remove MQTT System Broker #12157

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 29, 2022

Resolve #11848

It seems to work fine on my system.

Considering that MQTT is a key part in OpenHAB, it would be a great idea to test this. It can be compiled from my branch, or if you trust a jar: https://github.com/jimtng/openhab-addons/releases/download/v0.0.1/org.openhab.binding.mqtt-3.3.0-SNAPSHOT.jar

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Jan 29, 2022
@lolodomo
Copy link
Contributor

lolodomo commented Feb 2, 2022

The code to remove is ok for me.
I would like to be confirmed that this removal is expected.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 36ab0cd into openhab:main Feb 2, 2022
@lolodomo lolodomo added this to the 3.3 milestone Feb 2, 2022
@jimtng jimtng deleted the mqtt-systembroker branch February 3, 2022 00:54
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/mqtt-system-broker-no-more-selectable-after-upgarde-to-3-3-0-m2-from-m1/133874/2

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/frigate-nvr-binding/133908/7

wborn added a commit to wborn/openhab-addons that referenced this pull request Mar 13, 2022
The MqttService was used to keep track of the system MQTT brokers.
Since there are none the dependency can be removed.

Related to: openhab/openhab-core#2842
See also: openhab#12157

Signed-off-by: Wouter Born <github@maindrain.net>
jlaur pushed a commit that referenced this pull request Mar 13, 2022
The MqttService was used to keep track of the system MQTT brokers.
Since there are none the dependency can be removed.

Related to: openhab/openhab-core#2842
See also: #12157

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-distro that referenced this pull request Mar 18, 2022
* Instruct users to replace their things
* Remove mqttbroker.config

See also:

* openhab/openhab-addons#12157
* openhab/openhab-core#2842

Signed-off-by: Wouter Born <github@maindrain.net>
cweitkamp pushed a commit to openhab/openhab-distro that referenced this pull request Mar 23, 2022
* Instruct users to replace their things
* Remove mqttbroker.config

See also:

* openhab/openhab-addons#12157
* openhab/openhab-core#2842

Signed-off-by: Wouter Born <github@maindrain.net>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
The MqttService was used to keep track of the system MQTT brokers.
Since there are none the dependency can be removed.

Related to: openhab/openhab-core#2842
See also: openhab#12157

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jun 29, 2022
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
The MqttService was used to keep track of the system MQTT brokers.
Since there are none the dependency can be removed.

Related to: openhab/openhab-core#2842
See also: openhab#12157

Signed-off-by: Wouter Born <github@maindrain.net>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
The MqttService was used to keep track of the system MQTT brokers.
Since there are none the dependency can be removed.

Related to: openhab/openhab-core#2842
See also: openhab#12157

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
The MqttService was used to keep track of the system MQTT brokers.
Since there are none the dependency can be removed.

Related to: openhab/openhab-core#2842
See also: openhab#12157

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on (potentially) not backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mqtt] remove System Broker Thing from v3 binding
5 participants