-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mqtt] Remove MQTT System Broker #12157
Conversation
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
The code to remove is ok for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/frigate-nvr-binding/133908/7 |
The MqttService was used to keep track of the system MQTT brokers. Since there are none the dependency can be removed. Related to: openhab/openhab-core#2842 See also: openhab#12157 Signed-off-by: Wouter Born <github@maindrain.net>
The MqttService was used to keep track of the system MQTT brokers. Since there are none the dependency can be removed. Related to: openhab/openhab-core#2842 See also: #12157 Signed-off-by: Wouter Born <github@maindrain.net>
* Instruct users to replace their things * Remove mqttbroker.config See also: * openhab/openhab-addons#12157 * openhab/openhab-core#2842 Signed-off-by: Wouter Born <github@maindrain.net>
* Instruct users to replace their things * Remove mqttbroker.config See also: * openhab/openhab-addons#12157 * openhab/openhab-core#2842 Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
The MqttService was used to keep track of the system MQTT brokers. Since there are none the dependency can be removed. Related to: openhab/openhab-core#2842 See also: openhab#12157 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
The MqttService was used to keep track of the system MQTT brokers. Since there are none the dependency can be removed. Related to: openhab/openhab-core#2842 See also: openhab#12157 Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
The MqttService was used to keep track of the system MQTT brokers. Since there are none the dependency can be removed. Related to: openhab/openhab-core#2842 See also: openhab#12157 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
The MqttService was used to keep track of the system MQTT brokers. Since there are none the dependency can be removed. Related to: openhab/openhab-core#2842 See also: openhab#12157 Signed-off-by: Wouter Born <github@maindrain.net>
Resolve #11848
It seems to work fine on my system.
Considering that MQTT is a key part in OpenHAB, it would be a great idea to test this. It can be compiled from my branch, or if you trust a jar: https://github.com/jimtng/openhab-addons/releases/download/v0.0.1/org.openhab.binding.mqtt-3.3.0-SNAPSHOT.jar