Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MQTT system broker leftovers #2842

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Remove MQTT system broker leftovers #2842

merged 1 commit into from
Mar 17, 2022

Conversation

wborn
Copy link
Member

@wborn wborn commented Mar 13, 2022

The MqttService was used to keep track of the system MQTT brokers.
Since there are none it can be removed as well as the observer, tests, configuration and translations.

Fixes #2841

@wborn wborn added bug An unexpected problem or unintended behavior of the Core API breaking labels Mar 13, 2022
@wborn wborn requested a review from a team as a code owner March 13, 2022 20:21
wborn added a commit to wborn/openhab-addons that referenced this pull request Mar 13, 2022
@wborn
Remove MQTT system broker leftovers
11a7cee 
The MqttService was used to keep track of the system MQTT brokers.
Since there are none the dependency can be removed.

Related to: openhab/openhab-core#2842
See also: openhab#12157

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this pull request Mar 13, 2022
Merged
@wborn
Remove MQTT system broker leftovers
9829ed0 
The MqttService was used to keep track of the system MQTT brokers.
Since there are none it can be removed as well as the observer, tests, configuration and translations.

Fixes openhab#2841

Signed-off-by: Wouter Born <github@maindrain.net>
jlaur pushed a commit to openhab/openhab-addons that referenced this pull request Mar 13, 2022
@wborn
Remove MQTT system broker leftovers (#12472)
a47a105 
The MqttService was used to keep track of the system MQTT brokers.
Since there are none the dependency can be removed.

Related to: openhab/openhab-core#2842
See also: #12157

Signed-off-by: Wouter Born <github@maindrain.net>
@kaikreuzer
Copy link
Member

Hm, I'm just wondering: We are removing all this now, because we do not have the "embedded MQTT broker" add-on anymore available, right?
This embedded broker was just one possible "System MQTT broker", though. The MQTT service in general is about "system-wide configured Mqtt broker connections".
In general I'd claim it makes sense in many cases to configure a single MQTT broker for the whole system and make use of this in different add-ons - that was the intention of this at least.
I am not sure, though, if there are any add-ons besides the MQTT binding making use of MQTT brokers (I remember that there was this requirement, though, I just do not remember if any add-on made it into the official distro). If this is not the case, we might indeed wipe this feature.

@wborn
Copy link
Member Author

wborn commented Mar 14, 2022

Yes the system wide brokers make sense. Though the only place that I found where it was used was in the MQTT binding and it got removed with openhab/openhab-addons#12157. So either that PR should be reverted (and openhab/openhab-addons#12472) or the whole feature should be removed because it is now confusing to users as you can configure the system wide broker but it can no longer be used. 😉

@wborn wborn mentioned this pull request Mar 15, 2022
Closed
@kaikreuzer
Copy link
Member

Ok, so let's conclude that the idea was nice, but it never took off and is now rather confusing users. So it's time to remove it. 😎

@kaikreuzer kaikreuzer merged commit 9e33db6 into openhab:main Mar 17, 2022
@kaikreuzer kaikreuzer added this to the 3.3 milestone Mar 17, 2022
@wborn wborn deleted the mqtt-leftovers branch March 17, 2022 18:46
wborn added a commit to wborn/openhab-distro that referenced this pull request Mar 18, 2022
@wborn
Add update instructions for removed MQTT System Broker
fad9c6f 
* Instruct users to replace their things
* Remove mqttbroker.config

See also:

* openhab/openhab-addons#12157
* openhab/openhab-core#2842

Signed-off-by: Wouter Born <github@maindrain.net>
This was referenced Mar 18, 2022
Merged
Merged
cweitkamp pushed a commit to openhab/openhab-distro that referenced this pull request Mar 23, 2022
@wborn
Add update instructions for removed MQTT System Broker (#1380)
79cc7ca 
* Instruct users to replace their things
* Remove mqttbroker.config

See also:

* openhab/openhab-addons#12157
* openhab/openhab-core#2842

Signed-off-by: Wouter Born <github@maindrain.net>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@wborn @NickWaterton
Remove MQTT system broker leftovers (openhab#12472)
4cba526 
The MqttService was used to keep track of the system MQTT brokers.
Since there are none the dependency can be removed.

Related to: openhab/openhab-core#2842
See also: openhab#12157

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@wborn @andan67
Remove MQTT system broker leftovers (openhab#12472)
2f79b13 
The MqttService was used to keep track of the system MQTT brokers.
Since there are none the dependency can be removed.

Related to: openhab/openhab-core#2842
See also: openhab#12157

Signed-off-by: Wouter Born <github@maindrain.net>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@wborn @andrasU
Remove MQTT system broker leftovers (openhab#12472)
e99308c 
The MqttService was used to keep track of the system MQTT brokers.
Since there are none the dependency can be removed.

Related to: openhab/openhab-core#2842
See also: openhab#12157

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@wborn @psmedley
Remove MQTT system broker leftovers (openhab#12472)
dd3ecd7 
The MqttService was used to keep track of the system MQTT brokers.
Since there are none the dependency can be removed.

Related to: openhab/openhab-core#2842
See also: openhab#12157

Signed-off-by: Wouter Born <github@maindrain.net>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@wborn @splatch
Remove MQTT system broker leftovers (openhab#2842)
76f21e8 
The MqttService was used to keep track of the system MQTT brokers.
Since there are none it can be removed as well as the observer, tests, configuration and translations.

Fixes openhab#2841

Signed-off-by: Wouter Born <github@maindrain.net>
GitOrigin-RevId: 9e33db6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
API breaking bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

MQTT System broker still in settings
2 participants
@wborn @kaikreuzer