Use Item tags for tile icon suggestion #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think AS is wrong there, as - AFAIK - |
With and without these functions the unit tests I added fail. So both, the auto generated one by AS and the auto generated one by Kotlin, are invalid. |
|
I did some more testing: For Items without |
I used an array for the tags, because it can be put in a bundle. Android Studio suggested to override `equals()` and `hashCode()`, so I added the auto generated functions. Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
|
maniac103@0b8e571 is the fix for the issue - its commit message has the explanation for the failure ;-) See here for the Array vs. List difference. |
- The automatically generated equals() method for ParsedState failed, since Location doesn't have an equals method and thus reference equality was checked, which is not what we intended - The tags field also was compared by reference instead of by value, (which is a notable difference between Array<*>, which is compared by reference, and List<*>, which is compared by value) Signed-off-by: Danny Baumann <dannybaumann@web.de>
maniac103
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used an array for the tags, because it can be put in a bundle. Android Studio suggested to override
equals()andhashCode(), so I added the auto generated functions.Signed-off-by: mueller-ma mueller-ma@users.noreply.github.com