Add beacon based sitemap selection #213 #252

fspiekermann · 2016-11-25T08:09:52Z

I added beacon based sitemap selection, like described in Feature Proposal [#213].

Implements Bluetooth low energy (BLE) support for beacons in 'AbstractLocateBeacons'. Based on the Android version the 'MainActivity' will create a 'LocateBeaconsTask' with the belonging BLE API. To show the beacons, a new fragment ('NearRooms') is created. The location of a beacon is set in 'OpenHABWriteBeaconActivity', like a NFC-Tag. The 'BluetoothStateBroadcastReceiver' checks whether the user turns off Bluetooth while scanning for beacons and hold the 'Bluetoothadapter' enabled until the BLE scanner is shut down. The 'BeaconHandler' will handle the known and founded beacons for the whole system.

I have added two new menu items, one to start the localization and one to set the actual sitemap to the Beacon. . To set the beacon position an activity was created, which looks like the one from NFC-Tag. In the 'NearRoom' fragment it is possible to get an overview of all near beacons. Unknown beacons get the name 'UNKOWN'.

Implements Bluetooth low energy (BLE) support for beacons in AbstractLocateBeacons. Based on the Android version the MainActivity will create a LocateBeaconsTask with the belonging BLE API. To show the beacons, a new fragment (NearRooms) is created. The location of a beacon is set in OpenHABWriteBeaconActivity, like a NFC-Tag. The BluetoothStateBroadcastReceiver checks whether the user turns off Bluetooth while scanning for beacons and hold the Bluetoothadapter enabled until the BLE scanner is shut down. The BeaconHandler will handle the known and founded beacons for the whole system.

…213-beacon-based-sitemaps # Conflicts: # mobile/src/main/java/org/openhab/habdroid/ui/OpenHABMainActivity.java # mobile/src/main/java/org/openhab/habdroid/util/Constants.java # mobile/src/main/res/values-de/strings.xml

digitaldan · 2016-11-29T18:17:21Z

Hi thanks for the PR, I'm a little busy over the next few days, but I hope to get to it over the weekend.

digitaldan · 2016-12-28T17:49:25Z

Hi, couple of comments before I go through the code.

pressing "Set Beacon position" crashes the app ( i don't have a beacon yet discovered).
I managed to link to a RadBeacon, but at first it was not clear when trying to "save" a beacon what was happening (there was this small line that said something like "click here" but it was buried in text).
I linked a sitemap page to a beacons, but now what? Not sure what is suppose to happen. I would expect that if the app opens and is near a beacon it would go to that sitemap fragment?
How do I remove a beacon so I can scan and link again?
What does locate in the menu do? is this needed to discover beacons? Or is this required to to locate beacons you have already added or both? Should this be in the preference menu instead (enable bluetooth proximity) ?

fspiekermann · 2017-01-02T12:41:49Z

Hi,

That the app crashes, by pressing "Set Beacon position", I can't rebuild. In all my tests it never happened. Could you tell me when it happens?
The "Set Beacon position" activity I have to revise. I have done some usability tests for this activity and the most of the test persons couldn't get the functionality. At the moment the nearest Beacon will be set to the last Sitemap fragment. I am thinking about a dropdown-menu to choose which beacon will be set. Further on there have to be a better response after setting a beacon and the text have to be more understandable.
At the moment it isn't possible to remove a beacon, it only can be overwritten, when it is set to a new Sitemap fragment.
3/5. Locate starts the Bluetooth scan. So Beacons will be discovered and ordered by the distance. If the nearest Beacon is link to a Sitemap Fragment, the App will change to the linked fragment, but only when the app is open. So Locate is both, discovery und locate.
I put it in the menu, that the user will be able to start/stop the location without switching to the preference menu

At the moment I am very busy, writing my Bachelor thesis, but after it I am looking forward to work on it

* Modified encoding of passwords. Loading of images failed if the password contains a line terminator. * Improved error handling in case of http response code greater or equal 400 Signed-off-by: Volker Daube <vd-github@online.de> (github: Snickermicker)

Signed-off-by: Wouter Born <eclipse@maindrain.net>

Implements Bluetooth low energy (BLE) support for beacons in AbstractLocateBeacons. Based on the Android version the MainActivity will create a LocateBeaconsTask with the belonging BLE API. To show the beacons, a new fragment (NearRooms) is created. The shown beacons are clickable to manage the beacon or change to the belonging sitemap fragment. The location of a beacon is set in OpenHABWriteBeaconActivity, like a NFC-Tag. The BluetoothStateBroadcastReceiver checks whether the user turns off Bluetooth while scanning for beacons and hold the Bluetoothadapter enabled until the BLE scanner is shut down. The BeaconHandler will handle the known and founded beacons for the whole system.

fspiekermann · 2017-02-09T11:09:59Z

Hi,

1.) I have added longclick functions to NearRoomFragment, to remove or edit a beacon.

2.) Before setting a beacon, a list of all near beacons is shown, to choose the beacon which will be set.
3.) I added dropdown menus for Sitemap and Group in OpenHABWriteBeaconActivity.

4.) After this changes the App should not crash, after clicking set Beacon Position.

kaikreuzer · 2018-04-20T21:15:01Z

It seems to me that this had been closed by accident (which is a pity as it is imho a wonderful feature).

@fspiekermann Are you still around (even a year after finishing your thesis) and not too upset that you have never got further feedback here? If so I'd love to revive it as the Android app has gained some new momentum (thanks to @mueller-ma and @maniac103!). Wdyt?

mueller-ma · 2018-04-21T09:49:55Z

This sounds like a very interessting feature. I'll reopen it

stickler-ci · 2018-04-21T09:50:00Z

I couldn't find a .stickler.yml file in this repository. I can make one for you, or you can create one by following the documentation.

kthoms · 2018-04-21T10:37:59Z

Note that @fspiekermann is currently writing his master thesis on a different topic. So time is very limited and he might need support to work together on this. Let‘s see what he can tell.

kaikreuzer · 2018-04-23T08:54:43Z

currently writing his master thesis on a different topic. So time is very limited

Haha, I would think that time constraints will be much worse once he isn't a student anymore, but takes on a job :-)

Tony080 · 2018-04-24T22:54:01Z

Hello, My name is Chengzhi Hu. I'm a graduate student interested in this PR and I'm also enrolled in Eclipse "Integrate openHAB with Google's Physical Web" project from GSoC.
For now, I have merged openHAB master and this PR branch into my local git. And I have done some dummy staffs of reading URL from Eddystone beacons.
I'll move this PR forward and finish what @fspiekermann wish to do.

mueller-ma · 2018-04-25T03:52:31Z

Hey, sounds great. Please note that some modifications have to be made, e.g. not adding strings to values-* directories and using autovalue for OpenhabBeacons.java

Tony080 · 2018-04-25T05:12:28Z

@mueller-ma Thanks for the notifications.
I understand that I can only add English values if necessary during development. For other languages translations, I have to go Crowdin to submit my suggestions. BTW, I have already submitted some Chinese translation suggestions on Crowdin.
I'll follow your notice and read the contribution guidelines carefully in case I mess up the code.

kaikreuzer · 2018-05-18T06:17:10Z

This is superseded by #880.

Fabio Spiekermann added 3 commits November 25, 2016 08:40

mueller-ma and others added 6 commits February 9, 2017 11:29

updated german translation (openhab#259)

3b5d120

Added Japanese translation (openhab#254)

f3d383c

Improve WebView compatibility by enabling DOM storage (openhab#266)

5891d2f

Signed-off-by: Wouter Born <eclipse@maindrain.net>

Merge branch 'master' into 213-beacon-based-sitemaps

488eb44

digitaldan closed this Jun 19, 2017

mueller-ma reopened this Apr 21, 2018

Tony080 mentioned this pull request May 18, 2018

[WIP] BLE beacons & Google Physical Web support #880

Closed

kaikreuzer closed this May 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add beacon based sitemap selection #213 #252

Add beacon based sitemap selection #213 #252

fspiekermann commented Nov 25, 2016 •

edited

Loading

digitaldan commented Nov 29, 2016

digitaldan commented Dec 28, 2016

fspiekermann commented Jan 2, 2017

fspiekermann commented Feb 9, 2017

kaikreuzer commented Apr 20, 2018

mueller-ma commented Apr 21, 2018

stickler-ci commented Apr 21, 2018

kthoms commented Apr 21, 2018

kaikreuzer commented Apr 23, 2018

Tony080 commented Apr 24, 2018

mueller-ma commented Apr 25, 2018 •

edited

Loading

Tony080 commented Apr 25, 2018 •

edited

Loading

kaikreuzer commented May 18, 2018

Add beacon based sitemap selection #213 #252

Add beacon based sitemap selection #213 #252

Conversation

fspiekermann commented Nov 25, 2016 • edited Loading

digitaldan commented Nov 29, 2016

digitaldan commented Dec 28, 2016

fspiekermann commented Jan 2, 2017

fspiekermann commented Feb 9, 2017

kaikreuzer commented Apr 20, 2018

mueller-ma commented Apr 21, 2018

stickler-ci commented Apr 21, 2018

kthoms commented Apr 21, 2018

kaikreuzer commented Apr 23, 2018

Tony080 commented Apr 24, 2018

mueller-ma commented Apr 25, 2018 • edited Loading

Tony080 commented Apr 25, 2018 • edited Loading

kaikreuzer commented May 18, 2018

fspiekermann commented Nov 25, 2016 •

edited

Loading

mueller-ma commented Apr 25, 2018 •

edited

Loading

Tony080 commented Apr 25, 2018 •

edited

Loading