-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] BLE beacons & Google Physical Web support #880
Conversation
<string name="app_preferences_name">Settings</string> | ||
<string name="app_notifications">Notifications</string> | ||
<string name="dlg_notification_title">Notification message</string> | ||
<string name="favorites">Favorites</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tony-hu Looks like something got wrong with your merge. This and many other strings have been removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mueller-ma I assumed he wasn't done yet. There's also a lot of code this PR reintroduces that has been refactored out since the last PR was created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mueller-ma That's true. The basic situations are as @maniac103 said. I kept everything there as the merge result. And I'm currently deleting the unnecessary part to let it fit with the current version of openHAB.
Could not review pull request. It may be too large, or contain no reviewable changes. |
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
==========================================
- Coverage 14.37% 13.23% -1.15%
==========================================
Files 56 66 +10
Lines 4606 5034 +428
Branches 627 672 +45
==========================================
+ Hits 662 666 +4
- Misses 3883 4306 +423
- Partials 61 62 +1
Continue to review full report at Codecov.
|
…rance to the test BLE beacons activity. Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
…essages. Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
…sidebar menu. Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
…isplay. Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Hey @Tony-hu :) |
Hello @CasualTriangle ,
Basically, I plan to do both of them.
Yes, I agree with this point. Our topics are quite related. Perhaps we can share the same service to do the state change notifications to the openHAB server once the certain location changes? Or Google Location API has their own background service? I'm not familiar with Location API. Please correct me if I'm wrong. Thank you! |
…ove unnecessary SwipeRefreshLayout. Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
… nearest beacon with name now. Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
…articular beacon. Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
…lar beacon. Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
…awer. Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
@Tony-hu What ble beacon can you recommend for testing this PR? |
@mueller-ma I'm using the Blue Charm beacons. Here is the link I purchased on |
Signed-off-by: Chengzhi Hu <tony.hu1213@gmail.com>
Amazon isn't shipping this beacon to Germany, so I bought a different one (only iBeacon). I granted the location permisson, but when I open "Test BLE Beacon" and click on the fab, I only see an empty page. Log:
The last message is repeated over and over. I can see the beacon in the Android Bluetooth settings under "Available devices" (not paired). I have also noticed that the app crashes when I revoke the location permission and the app should only ask for it when the user wants to add a beacon. |
@mueller-ma Thanks for the feedback. I'll take a look at the problem. |
Hey @Tony-hu, |
@mueller-ma Thanks for reaching out! I'm currently busying in seeking jobs, and I'm going to graduate in December. So, I just suspend the development process. |
What are the next steps to push this idea? |
Hello, I'm a student developer enrolled in GSoC 2018. This PR is dedicated to adding BLE beacons(Eddystone, iBeacons, and etc.) and Google Physical Web support to openHAB 2 Android.
Currently, I just merged PR #252 to the newest openHAB 2, and I'm going to move that PR forward. However, I'm still working in progress.
06.19 UI update
06.14 Feature update
Add an activity "Location tracking" for displaying all known
![](https://raw.githubusercontent.com/Tony-Hu/openhab-android/eddystone-beacon/screenshots/location_tracking_06_14_2018.png)
![](https://raw.githubusercontent.com/Tony-Hu/openhab-android/b39c2f638f3d09ae6e54cb83574bbf2e3308a2d2/screenshots/config_eddystone_url.jpg)
![](https://raw.githubusercontent.com/Tony-Hu/openhab-android/b39c2f638f3d09ae6e54cb83574bbf2e3308a2d2/screenshots/config_others.jpg)
Beacon - Frame
pairs.And, to bind beacon with frames, another setting activity is introduced.
06.05 Feature update
Build a BLE scan service to scan BLE beacons in the background. Auto display and update results on "Test BLE Beacons".
SwipeRefreshLayout
is removed.05.27 Feature update
From now on, you can detect Eddystone URL & UID beacons, iBeacons from openHAB. Here are the steps:
![](https://raw.githubusercontent.com/Tony-Hu/openhab-android/eddystone-beacon/screenshots/how_to_enter.jpeg)
And then, you enter the activity with the scan result. The scan is lasting for 10 seconds for now. And I'm fixing with the animations as my next step. Finally, you will get the results as shown below:
![](https://raw.githubusercontent.com/Tony-Hu/openhab-android/eddystone-beacon/screenshots/ble_activity.png)
Please tell me if there is any kind of crash. Thank you!